Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Allow extra spaces in next-version tags #21647

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Nov 4, 2021

Changes proposed in this Pull Request:

Some people like to align things.

Jetpack product discussion

#21520 (comment)

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Try adding @since $$next-version$$ or @deprecated since $$next-version$$ somewhere. Then run tools/replace-next-version-tag.sh over it.

Some people like to align things.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Low labels Nov 4, 2021
@anomiex anomiex requested a review from sdixon194 November 4, 2021 17:15
@anomiex anomiex self-assigned this Nov 4, 2021
@anomiex anomiex enabled auto-merge (squash) November 4, 2021 17:15
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 4, 2021
@anomiex anomiex merged commit 1660fb7 into master Nov 4, 2021
@anomiex anomiex deleted the fix/next-version-extra-spaces branch November 4, 2021 18:09
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 4, 2021
davidlonjon added a commit that referenced this pull request Nov 5, 2021
# By Brad Jorsch (2) and others
# Via GitHub
* master:
  Boost: Fix the official name to the JavaScript word reference (#21638)
  tools: Allow extra spaces in next-version tags (#21647)
  Publicize: always add an alt text to Open Graph Images (#21520)
  js-tools: Add missing eslint plugin dep (#21642)
  * Deactivate SSO in e2e environment (#21644)
  Publicize: Handling feature availability information and upgrading (#21567)
  Nav Unification: Remove `preferred-view` param after update (#21632)
  [Plugin] Backup: Update/upgrade button link (#21590)

# Conflicts:
#	projects/plugins/boost/app/assets/src/js/pages/settings/sections/Modules.svelte
davidlonjon added a commit that referenced this pull request Nov 9, 2021
* master: (24 commits)
  Update dependency preact to v10.5.15 (#21635)
  Search: Migrate helper classes to standalone package (#21552)
  Release script: fix small typo (#21675)
  Update babel monorepo (#21668)
  Lock file maintenance (#21664)
  E2E tests: clean unused dependencies (#21639)
  Create JS Config package (#21592)
  Use webpack config JS package in Jetpack (#21581)
  add test runner to dev dependencies (#21591)
  Pexels Integration: Make the initial image search for example query run only once (#21641)
  Boost: make progress bar corners round on small screens (#21626)
  Full Sync :: limit to contributors and above (#21648)
  Sync Checksums : limit users based on user_level (#21645)
  Storybook: add Jetpack Spinner (#21511)
  Contact Info and Map widget: widget deprecation (#21554)
  Use webpack config js package in everything except Jetpack (#21580)
  Boost: Fix the official name to the JavaScript word reference (#21638)
  tools: Allow extra spaces in next-version tags (#21647)
  Publicize: always add an alt text to Open Graph Images (#21520)
  js-tools: Add missing eslint plugin dep (#21642)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants