Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetpack-mu-wpcom: migrate Automattic/wp-calypso/pull/71541 #28903

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

samiff
Copy link
Contributor

@samiff samiff commented Feb 10, 2023

Proposed changes:

Migrates Automattic/wp-calypso/pull/71541 which happened after the initial move of coming-soon from ETK.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Proofread.

@samiff samiff added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal [Package] Jetpack mu wpcom WordPress.com Features labels Feb 10, 2023
@samiff samiff self-assigned this Feb 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@samiff samiff enabled auto-merge (squash) February 10, 2023 19:38
@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 10, 2023
@samiff samiff merged commit b83f991 into trunk Feb 10, 2023
@samiff samiff deleted the update/jetpack-mu-wpcom-coming-soon branch February 10, 2023 19:49
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants