-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix response for home template in /pages for Coming Soon sites #71541
Conversation
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like this way doesn't work when the Privacy of the atomic site is set to "Private" 😔 |
* Migrate Automattic/wp-calypso/pull/71541 * Fixup project versions
* Migrate Automattic/wp-calypso/pull/71541 * Fixup project versions Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4147183456
* Migrate Automattic/wp-calypso/pull/71541 * Fixup project versions Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4147183456
* Migrate Automattic/wp-calypso/pull/71541 * Fixup project versions Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4147183456
Proposed Changes
template_redirect
returns a HTML response instead of a JSON response expected herenull
response forhttps://public-api.wordpress.com/wpcom/v2/sites/:blog_id/block-editor?_envelope=1
(notice the
null
values inhome_template
), which then prevents the Homepage template from being rendered (screenshots below)Testing Instructions
This is a fix for atomic sites in "Coming Soon" mode.
https://public-api.wordpress.com/wpcom/v2/sites/:blog_id/block-editor?_envelope=1
Feel free to test around the issue to see if private atomic/simple sites are functioning correctly.
Pre-merge Checklist
Have you written new tests for your changes?Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to DataHave we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?Fixes #71375