-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Boost: Split and Parallelize Jetpack Boost Tests #32686
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Boost plugin:
|
60663dd
to
f911559
Compare
This reverts commit f911559.
62b87d8
to
51e17be
Compare
This reverts commit 492d868.
87e08c0
to
b4ab52f
Compare
* Create both the test and build matrices in `create-test-matrix`. * Generate an empty build matrix if no build is needed. * Don't generate build entries for "atomic" suites. * Check build matrix for having more than one path. * Skip `build-projects` job if the matrix is empty. * Remove suite check in `build-projects` build step since we do it in `create-test-matrix` now. * We have to run `e2e-tests` even if `build-projects` is skipped, but not it `create-test-matrix` was skipped. * Skip `e2e-tests` if test matrix is empty, otherwise GH complains. * Only restore build artifact if we need it. * Complain if build job wasn't skipped when it should have been. * Complain if artifact restore didn't when it should have. * Revert changes to reporting jobs' conditions.
…ged files insead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this broke the I'll look at making a followup PR. |
During all the code rearranging in Automattic#32686, a piece of code that was only for the workflow_run version wound up being incorrectly run for repository_dispatch as well.
During all the code rearranging in #32686, a piece of code that was only for workflow_run wound up being incorrectly run for repository_dispatch as well.
During all the code rearranging in #32686, a piece of code that was only for workflow_run wound up being incorrectly run for repository_dispatch as well.
…ts (#32686) * Split Boost tests into directories * Run Jetpack Boost tests in parallel * Add changelog entry. * Invalid colon * [test] cache artifacts & build artifacts * Revert "[test] cache artifacts & build artifacts" This reverts commit f911559. * Introduce build groups * Add strategy * Correct artifact directory * Cache build output * Use v3 cache * Replace artifacts with cache * Attempt to fix paths * Use changed files as the cache hash * Revert "Use changed files as the cache hash" This reverts commit 492d868. * Fix cache paths * Cache the whole matrix path directory * Skipped jobs are ok * Fix the key * Cache the whole directory, not just matrix path * Always run slack notification and test report * Rename "Setup" to "Base" To avoid conflicting naming throughout the workflow runs. "Setup" is kind of confusing. * Revert "Always run slack notification and test report" This reverts commit d5d5125. * Remove always() * Matrix over concurrency * Ensure build cache * Group Jetpack projects into jetpack-core * Restore repo check * build-matrix -> matrix * Fetch the build matrix * Don't need the project name here * Clean up job flow * Create both the test and build matrices in `create-test-matrix`. * Generate an empty build matrix if no build is needed. * Don't generate build entries for "atomic" suites. * Check build matrix for having more than one path. * Skip `build-projects` job if the matrix is empty. * Remove suite check in `build-projects` build step since we do it in `create-test-matrix` now. * We have to run `e2e-tests` even if `build-projects` is skipped, but not it `create-test-matrix` was skipped. * Skip `e2e-tests` if test matrix is empty, otherwise GH complains. * Only restore build artifact if we need it. * Complain if build job wasn't skipped when it should have been. * Complain if artifact restore didn't when it should have. * Revert changes to reporting jobs' conditions. * Try caching only added files * Source funcs file before the cd * Remove workflow_run stuff, trigger was removed in #27623 last year * Need to cd back to GITHUB_WORKSPACE for the after `find` anyway * Can't pass too long of a list to actions/cache/save. So remove unchanged files insead. * Can't delete `./.github`, it breaks "Post Setup tools". * Sigh, xargs * `path` needs to match, sigh * Remove the extra dollar 💸 --------- Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com>
During all the code rearranging in #32686, a piece of code that was only for workflow_run wound up being incorrectly run for repository_dispatch as well.
Proposed changes:
Other information:
N/A
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
N/A
Testing instructions: