Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix e2e repository_dispatch run #32764

Merged
merged 1 commit into from
Aug 30, 2023
Merged

ci: Fix e2e repository_dispatch run #32764

merged 1 commit into from
Aug 30, 2023

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Aug 30, 2023

Proposed changes:

During all the code rearranging in #32686, a piece of code that was only for workflow_run wound up being incorrectly run for repository_dispatch as well.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

#32686 (comment)

Does this pull request change what data or activity we track or use?

No

Testing instructions:

During all the code rearranging in #32686, a piece of code that was only
for workflow_run wound up being incorrectly run for repository_dispatch
as well.
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal labels Aug 30, 2023
@anomiex anomiex self-assigned this Aug 30, 2023
@anomiex anomiex enabled auto-merge (squash) August 30, 2023 15:09
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Aug 30, 2023
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@anomiex anomiex merged commit 04f3a0c into trunk Aug 30, 2023
52 checks passed
@anomiex anomiex deleted the fix/e2e-repo-dispatch branch August 30, 2023 19:01
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Aug 30, 2023
TimBroddin pushed a commit that referenced this pull request Sep 5, 2023
During all the code rearranging in #32686, a piece of code that was only
for workflow_run wound up being incorrectly run for repository_dispatch
as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants