Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stats data building to new function #3445

Merged
merged 1 commit into from
Mar 2, 2016
Merged

Move stats data building to new function #3445

merged 1 commit into from
Mar 2, 2016

Conversation

mjangda
Copy link
Member

@mjangda mjangda commented Feb 24, 2016

Changes proposed in this Pull Request:

This new function will allow reuse of the stats data needed to create the stats pixel, in contexts like AMP.

@mjangda
Move stats data building to new function
c4ac09c 
This will allow reuse of the stats data needed to create the stats
pixel, in contexts like AMP.
@mjangda mjangda added [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Feb 24, 2016
@jeherve jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Feb 24, 2016
@jeherve jeherve added this to the 3.9.3 milestone Feb 24, 2016
@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 29, 2016
@eliorivero
Copy link
Contributor

lgtm 👍
Minor thing: is that heredoc necessary? let's leave it, but in this case it doesn't seem to be necessary.

@mjangda
Copy link
Member Author

mjangda commented Feb 29, 2016

Heredoc is definitely not necessary; just a legacy thing.

@zinigor zinigor merged this pull request into master Mar 2, 2016
@zinigor zinigor deleted the add/stats-data-function branch March 2, 2016 10:47
@zinigor zinigor removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 2, 2016
This was referenced Mar 17, 2016
Closed
Merged
@bantilan bantilan mentioned this pull request Dec 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
3.9.3
Development

Successfully merging this pull request may close these issues.
5 participants
@mjangda @eliorivero @zinigor @jeherve @georgestephanis