General: merge again commits that were deleted from master by force push #3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeherve
added
[Type] Bug
jeherve
added
[Status] In Progress
and removed
[Status] Needs Review
Fixes #3495 If the theme doesn't set `$content_width`, we set a default, `640`, like for YouTube.
Previously the conditional would give a wrong result when there is no content_width, which was breaking the tests.
In XHTML, attribute minimization is forbidden. `async` and `defer` must be defined as `<script async='async' defer='defer'>`. Suggested here: https://wordpress.org/support/topic/doesnt-work-with-xhtml-2
When creating a very simple form, no data is saved in post meta when the form is submitted. This PR creates an enpty $post_meta_data array to avoid errors when there is no post meta data. Fixes #3460
jeherve
force-pushed
the
before-force-push-one
branch
from
8ea9c4c to
0beaf3b
Compare
jeherve
added
[Status] Needs Review
added 2 commits
March 17, 2016 14:53
We wrap YouTube videos in a span for some CSS alignment stuff. We don't need that in feeds, and it could muck up other plugins so let's remove it.
jeherve
added
[Status] In Progress
and removed
[Status] Needs Review
This will allow reuse of the stats data needed to create the stats pixel, in contexts like AMP.
jeherve
added
[Status] Needs Review
dereksmart
added
[Status] Ready to Merge
zinigor
added a commit
that referenced
this pull request
Mar 22, 2016
General: merge again commits that were deleted from master by force push
zinigor
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge again commits that were deleted from master by force push
#3497 - Vimeo: set default width if $content_width isn't set
#3489 - Stats: update Stats script to be valid XHTML
#3461 - Contact Form: fix fatal error when no post meta exists for forms
#3445 - Move stats data building to new function
#3438 - Remove YouTube alignment CSS in feeds