-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect: Add Go to Cloud and Scan now to header #40057
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Since this doesn't remove the buttons from the body, should we stack this on #40076? |
c6fdeba
to
34d2495
Compare
a289dc0
to
df753cd
Compare
34d2495
to
e28752c
Compare
5add855
to
8bdd332
Compare
e28752c
to
5dc1c92
Compare
b918042
to
c42cb9b
Compare
c42cb9b
to
8ae2b3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: Rebased on to add/protect/core
project branch.
LGTM
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
#40057) Co-authored-by: Nate Weller <hello@nateweller.com>
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
Descritpion
Adds
Go to Cloud
andScan now
buttons to the primary Jetpack Protect header when a plan is found and a use is viewing a Scan page.Note: This PR does not remove any existing buttons from the UI, this will need to addressed once the
ThreatsDataViews
component is implemented in ProtectOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Screenshots