Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: Add Go to Cloud and Scan now to header #40057

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Nov 5, 2024

Descritpion

Adds Go to Cloud and Scan now buttons to the primary Jetpack Protect header when a plan is found and a use is viewing a Scan page.

Note: This PR does not remove any existing buttons from the UI, this will need to addressed once the ThreatsDataViews component is implemented in Protect

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Use the Jetpack Beta Tester using this branch on Protect with a Scan upgrade
  • Verify that the two buttons display correctly in the header
  • Ensure that buttons do not render on a non-scan page and after downgrading
  • Validate that the functionality of each works

Screenshots

Screen Shot 2024-11-05 at 10 56 20

@github-actions github-actions bot added [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress labels Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@dkmyta dkmyta marked this pull request as ready for review November 8, 2024 16:39
@dkmyta dkmyta self-assigned this Nov 8, 2024
@nateweller
Copy link
Contributor

Since this doesn't remove the buttons from the body, should we stack this on #40076?

@nateweller nateweller force-pushed the add/protect/header-buttons branch from c6fdeba to 34d2495 Compare November 13, 2024 18:45
@nateweller nateweller changed the base branch from trunk to add/protect/threats-data-views November 13, 2024 18:45
@nateweller nateweller force-pushed the add/protect/threats-data-views branch from a289dc0 to df753cd Compare November 13, 2024 18:57
@nateweller nateweller force-pushed the add/protect/header-buttons branch from 34d2495 to e28752c Compare November 13, 2024 18:58
@nateweller nateweller force-pushed the add/protect/threats-data-views branch 4 times, most recently from 5add855 to 8bdd332 Compare November 14, 2024 18:22
@nateweller nateweller force-pushed the add/protect/header-buttons branch from e28752c to 5dc1c92 Compare November 14, 2024 18:31
@nateweller nateweller changed the base branch from add/protect/threats-data-views to add/protect/core November 14, 2024 18:32
@github-actions github-actions bot added [JS Package] Scan [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests RNA labels Nov 14, 2024
@nateweller nateweller force-pushed the add/protect/header-buttons branch 2 times, most recently from b918042 to c42cb9b Compare November 14, 2024 18:37
@nateweller nateweller force-pushed the add/protect/header-buttons branch from c42cb9b to 8ae2b3f Compare November 14, 2024 18:38
Copy link
Contributor

@nateweller nateweller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Rebased on to add/protect/core project branch.

LGTM :shipit:

@dkmyta dkmyta merged commit 2a99949 into add/protect/core Nov 14, 2024
49 checks passed
@dkmyta dkmyta deleted the add/protect/header-buttons branch November 14, 2024 19:03
nateweller added a commit that referenced this pull request Nov 19, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Nov 21, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Nov 25, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Nov 26, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Nov 28, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Nov 30, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 2, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 3, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 4, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 5, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 5, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 5, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
@nateweller nateweller mentioned this pull request Dec 5, 2024
3 tasks
nateweller added a commit that referenced this pull request Dec 6, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 8, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 9, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 10, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
dkmyta added a commit that referenced this pull request Dec 10, 2024
* Init project branch

* Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>

* Protect: Update Scan and History headers (#40058)

* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <nate.weller@automattic.com>

---------

Co-authored-by: Nate Weller <nate.weller@automattic.com>

* Protect: de-emphasize cloud link by using link variant (#40211)

* Protect: add ShieldIcon component

* Protect: Add ShieldIcon Component (#40402)

* Protect: Integrate ThreatsDataViews Component (#40076)

* Components: Add ScanReport (#40419)

* Fix type errors

* Protect: add home page

---------

Co-authored-by: Nate Weller <hello@nateweller.com>
Co-authored-by: Nate Weller <nate.weller@automattic.com>
Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
nateweller added a commit that referenced this pull request Dec 11, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 11, 2024
* Init project branch

* Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>

* Protect: Update Scan and History headers (#40058)

* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <nate.weller@automattic.com>

---------

Co-authored-by: Nate Weller <nate.weller@automattic.com>

* Protect: de-emphasize cloud link by using link variant (#40211)

* Protect: add ShieldIcon component

* Protect: Add ShieldIcon Component (#40402)

* Protect: Integrate ThreatsDataViews Component (#40076)

* Components: Add ScanReport (#40419)

* Fix type errors

* Protect: add home page

---------

Co-authored-by: Nate Weller <hello@nateweller.com>
Co-authored-by: Nate Weller <nate.weller@automattic.com>
Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
nateweller added a commit that referenced this pull request Dec 15, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 15, 2024
* Init project branch

* Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>

* Protect: Update Scan and History headers (#40058)

* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <nate.weller@automattic.com>

---------

Co-authored-by: Nate Weller <nate.weller@automattic.com>

* Protect: de-emphasize cloud link by using link variant (#40211)

* Protect: add ShieldIcon component

* Protect: Add ShieldIcon Component (#40402)

* Protect: Integrate ThreatsDataViews Component (#40076)

* Components: Add ScanReport (#40419)

* Fix type errors

* Protect: add home page

---------

Co-authored-by: Nate Weller <hello@nateweller.com>
Co-authored-by: Nate Weller <nate.weller@automattic.com>
Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
nateweller added a commit that referenced this pull request Dec 17, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 17, 2024
* Init project branch

* Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>

* Protect: Update Scan and History headers (#40058)

* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <nate.weller@automattic.com>

---------

Co-authored-by: Nate Weller <nate.weller@automattic.com>

* Protect: de-emphasize cloud link by using link variant (#40211)

* Protect: add ShieldIcon component

* Protect: Add ShieldIcon Component (#40402)

* Protect: Integrate ThreatsDataViews Component (#40076)

* Components: Add ScanReport (#40419)

* Fix type errors

* Protect: add home page

---------

Co-authored-by: Nate Weller <hello@nateweller.com>
Co-authored-by: Nate Weller <nate.weller@automattic.com>
Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
nateweller added a commit that referenced this pull request Dec 18, 2024
#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>
nateweller added a commit that referenced this pull request Dec 18, 2024
* Init project branch

* Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)

Co-authored-by: Nate Weller <hello@nateweller.com>

* Protect: Update Scan and History headers (#40058)

* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <nate.weller@automattic.com>

---------

Co-authored-by: Nate Weller <nate.weller@automattic.com>

* Protect: de-emphasize cloud link by using link variant (#40211)

* Protect: add ShieldIcon component

* Protect: Add ShieldIcon Component (#40402)

* Protect: Integrate ThreatsDataViews Component (#40076)

* Components: Add ScanReport (#40419)

* Fix type errors

* Protect: add home page

---------

Co-authored-by: Nate Weller <hello@nateweller.com>
Co-authored-by: Nate Weller <nate.weller@automattic.com>
Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Scan [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. RNA [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants