-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect: Add ShieldIcon Component #40402
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
4dea670
to
5656dbe
Compare
c0fbff8
to
c8406d5
Compare
47daee8
to
0af972e
Compare
c521812
to
293564e
Compare
c9e6762
to
62c5e58
Compare
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
daf25a2
to
a86a4b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great idea! This will be fantastic to use in the ScanReport
and Home page StatCards.
Nit - it's only a very subtle difference, but think it's possible that we can update the internal icon paths to match the designs?
We should now use this new component in Protect to replace the ProtectCheck
and its uses and the error icon in the ErrorAdminSectionHero
.
a2db115
to
c871fb1
Compare
Good points @dkmyta, and thanks for the review! 👍 I've updated the new |
293564e
to
a5a6565
Compare
Rebase on admin hero section refactor Revert accidental type changes Remove testing code Init project branch Protect: Add ShieldIcon Component (#40402) Refactor AdminSectionHero component
Rebase on admin hero section refactor Revert accidental type changes Remove testing code Init project branch Protect: Add ShieldIcon Component (#40402) Refactor AdminSectionHero component
Rebase on admin hero section refactor Revert accidental type changes Remove testing code Init project branch Protect: Add ShieldIcon Component (#40402) Refactor AdminSectionHero component
Rebase on admin hero section refactor Revert accidental type changes Remove testing code Init project branch Protect: Add ShieldIcon Component (#40402) Refactor AdminSectionHero component
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>
Proposed changes:
ShieldIcon
component for use in the Jetpack protect plugin. Replaces the existingAlertIcon
component.variant
property (i.e.default
,success
,warning
, orerror
) that controls the color and icon. However, thefill
andicon
properties can be set directly as well to override or opt-out of thevariant
.outline
prop is available to switch between the fill/border shield styles.Other information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Screenshots
Protect:
Storybook: