Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: Refactor AdminSectionHero #40516

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

nateweller
Copy link
Contributor

@nateweller nateweller commented Dec 9, 2024

Proposed changes:

  • Changes Protect's AdminSectionHero component to export sub-components, replacing the main and secondary props with AdminSectionHero.Main and AdminSectionHero.Aside.
// old implementation
<AdminSectionHero
    main={ (
        <>
            <AdminSectionHero.Heading showIcon variant="warning">
                Hello, World!
            </AdminSectionHero.Heading>
            <AdminSectionHero.Subheading>
                Code is poetry.
            </AdminSectionHero.Subheading>
        </>
    ) }
    mainClassName="my-main-class-name"
    secondary={ <img src="example.jpg" /> }
    preserveSecondaryOnMobile={ true }
/>

// proposed implementation
<AdminSectionHero>
    <AdminSectionHero.Main className="my-main-class-name">
        <AdminSectionHero.Heading icon="warning">
            Hello, World!
        </AdminSectionHero.Heading>
        <Text>
            Code is poetry.
        </Text>
    </AdminSectionHero.Main>
    <AdminSectionHero.Aside>
        <img src="example.jpg" />
    </AdminSectionHero.Aside>
</AdminSectionHero>
  • Adjust AdminSectionHero styling, use flexbox instead of grid.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

#40317 (comment)

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Review the page headers in Jetpack Protect on various screen sizes and states.

Screenshots

Screenshot 2024-12-08 at 7 46 30 PM Screenshot 2024-12-08 at 7 46 41 PM Screenshot 2024-12-08 at 7 47 25 PM

@nateweller nateweller added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review labels Dec 9, 2024
@nateweller nateweller requested review from dkmyta and a team December 9, 2024 02:44
@nateweller nateweller self-assigned this Dec 9, 2024
@github-actions github-actions bot added [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress labels Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@nateweller nateweller marked this pull request as ready for review December 9, 2024 16:47
@nateweller nateweller force-pushed the protect/refactor/admin-section-hero branch from 7cfe1d9 to d19007c Compare December 9, 2024 16:50
@nateweller nateweller force-pushed the protect/refactor/admin-section-hero branch from d19007c to cd16668 Compare December 9, 2024 16:52
@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 9, 2024
Copy link
Contributor

@dkmyta dkmyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements! Made note of one potential area for improvement and a minor nitpick.

In the scanning state at 1100px the inProgressAnimation wraps to a second line. Previously the main section shrunk to fit to a point when the animation became hidden. If thats no longer an option maybe we can just hide it earlier?
Screen Shot on 2024-12-09 at 10-28-26 (1)

Nit - should the FirewallPage status icon/label be spaced out further? Perhaps a similar margin (16px) as the lastCheckedLocalTimestamp in the ScanPage too keep things uniform?
Screen Shot on 2024-12-09 at 10-24-24 (1)

@nateweller nateweller requested a review from dkmyta December 9, 2024 20:07
@nateweller nateweller requested a review from dkmyta December 9, 2024 20:49
Copy link
Contributor

@dkmyta dkmyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nateweller nateweller merged commit 91ee20a into add/protect/core Dec 9, 2024
49 of 51 checks passed
@nateweller nateweller deleted the protect/refactor/admin-section-hero branch December 9, 2024 21:38
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Dec 9, 2024
nateweller added a commit that referenced this pull request Dec 10, 2024
nateweller added a commit that referenced this pull request Dec 11, 2024
@nateweller nateweller mentioned this pull request Dec 11, 2024
3 tasks
nateweller added a commit that referenced this pull request Dec 15, 2024
nateweller added a commit that referenced this pull request Dec 15, 2024
nateweller added a commit that referenced this pull request Dec 17, 2024
nateweller added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Components [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. RNA [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants