-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect: Refactor AdminSectionHero #40516
Protect: Refactor AdminSectionHero #40516
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
9745a5f
to
68569f2
Compare
7cfe1d9
to
d19007c
Compare
d19007c
to
cd16668
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements! Made note of one potential area for improvement and a minor nitpick.
In the scanning
state at 1100px
the inProgressAnimation
wraps to a second line. Previously the main section shrunk to fit to a point when the animation became hidden. If thats no longer an option maybe we can just hide it earlier?
Nit - should the FirewallPage
status icon/label be spaced out further? Perhaps a similar margin (16px
) as the lastCheckedLocalTimestamp
in the ScanPage
too keep things uniform?
projects/plugins/protect/src/js/routes/firewall/firewall-admin-section-hero.tsx
Outdated
Show resolved
Hide resolved
projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx
Outdated
Show resolved
Hide resolved
projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes:
AdminSectionHero
component to export sub-components, replacing themain
andsecondary
props withAdminSectionHero.Main
andAdminSectionHero.Aside
.AdminSectionHero
styling, use flexbox instead of grid.Other information:
Jetpack product discussion
#40317 (comment)
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Screenshots