Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title on the spam honeypot field #6332

Merged
merged 2 commits into from
Feb 10, 2017
Merged

Title on the spam honeypot field #6332

merged 2 commits into from
Feb 10, 2017

Conversation

singerb
Copy link
Contributor

@singerb singerb commented Feb 8, 2017

Per accessibility guidelines, this input should have a title or a label
to indicate what it's for. Fixes #3260

@singerb singerb added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 8, 2017
@jeherve jeherve added [Feature] Sharing Post sharing, sharing buttons [Focus] Accessibility Improving usability for all users (a11y) [Type] Bug When a feature is broken and / or not performing as intended labels Feb 8, 2017
jeherve
jeherve previously requested changes Feb 8, 2017
View reviewed changes
modules/sharedaddy/sharing-sources.php Outdated
@@ -514,7 +514,7 @@ public function display_footer() {
<input type="email" name="source_email" id="source_email" value="" />

<?php endif; ?>
<input type="text" id="jetpack-source_f_name" name="source_f_name" class="input" value="" size="25" autocomplete="off" />
<input type="text" id="jetpack-source_f_name" name="source_f_name" class="input" value="" size="25" autocomplete="off" title="This field is for validation and should not be changed" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make that label translatable? Thanks!

@jeherve jeherve added [Pri] Low [Status] In Progress [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 8, 2017
@singerb singerb added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 9, 2017
@singerb
Copy link
Contributor Author

singerb commented Feb 9, 2017

Doh, totally forgot translation even after doing it on the previous PR!

dereksmart
dereksmart approved these changes Feb 10, 2017
View reviewed changes
Copy link
Member

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just needs a rebase...

@dereksmart dereksmart dismissed jeherve’s stale review February 10, 2017 17:30

translation has been addressed

@singerb @eliorivero
Title on the spam honeypot field
3afd358 
Per accessibility guidelines, this input should have a title or a label
to indicate what it's for. Fixes #3260
@singerb @eliorivero
Make translatable
c90c8af 
New text should be translatable, and thus escaped.
@eliorivero eliorivero force-pushed the update/add-title-to-honeypot branch from feda2cf to c90c8af Compare February 10, 2017 20:06
@eliorivero
Copy link
Contributor

eliorivero commented Feb 10, 2017 •
edited
Loading

I've rebased this. It's good to be merged.

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 10, 2017
@samhotchkiss samhotchkiss merged commit 98c78e2 into master Feb 10, 2017
@samhotchkiss samhotchkiss deleted the update/add-title-to-honeypot branch February 10, 2017 22:52
@samhotchkiss samhotchkiss removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 10, 2017
jeherve added a commit that referenced this pull request Feb 21, 2017
@jeherve
Changelog: add #6332
0ff7e06
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
@jeherve @dereksmart
Jetpack 4.7: Changelog (#6331)
a9adf86 
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
jeherve added a commit that referenced this pull request Nov 13, 2017
@jeherve
Sharing: remove inline JS used in the hidden email sharing form.
948c7da 
This JS was previously removed in #6339, but then added back (I think during a rebase) in #6332.
@jeherve jeherve mentioned this pull request Nov 13, 2017
Merged
oskosk pushed a commit that referenced this pull request Nov 23, 2017
@jeherve @oskosk
Sharing: remove inline JS used in the hidden email sharing form. (#8149)
40e9a33 
This JS was previously removed in #6339, but then added back (I think during a rebase) in #6332.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereksmart dereksmart dereksmart approved these changes

@jeherve jeherve jeherve left review comments

Assignees
No one assigned
Labels
[Feature] Sharing Post sharing, sharing buttons [Focus] Accessibility Improving usability for all users (a11y) [Pri] Low Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@singerb @eliorivero @jeherve @dereksmart @samhotchkiss @matticbot