Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing: remove inline JS used in the hidden email sharing form. #8149

Merged
merged 1 commit into from
Nov 23, 2017
Merged

Sharing: remove inline JS used in the hidden email sharing form. #8149

merged 1 commit into from
Nov 23, 2017

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Nov 13, 2017

This JS was previously removed in #6339, but then added back (I think during a rebase) in #6332.

Proposed changelog entry for your changes:

  • Sharing: remove inline JavaScript used in the email sharing form.

Related: 774824-zen

@jeherve
Sharing: remove inline JS used in the hidden email sharing form.
948c7da 
This JS was previously removed in #6339, but then added back (I think during a rebase) in #6332.
@jeherve jeherve added [Feature] Sharing Post sharing, sharing buttons [Pri] Normal [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Nov 13, 2017
@jeherve jeherve self-assigned this Nov 13, 2017
@jeherve jeherve requested a review from a team as a code owner November 13, 2017 14:02
oskosk
oskosk approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Description of the regression makes total sense. 🐑

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 22, 2017
@oskosk oskosk added this to the 5.6 milestone Nov 23, 2017
@oskosk oskosk merged commit 40e9a33 into master Nov 23, 2017
@oskosk oskosk deleted the rm/sharing-email-inline-js branch November 23, 2017 18:51
@oskosk oskosk removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 23, 2017
jeherve added a commit that referenced this pull request Nov 24, 2017
@jeherve
Changelog: add #8149
96a747a
oskosk pushed a commit that referenced this pull request Nov 28, 2017
@jeherve @oskosk
Changelog 5.6: running changelog. (#8192)
7844644 
* Changelog 5.6: create base for changelog.

* Update changelog with 5.5.1 info.

* Changelog: add #7930 and #8238

* Changelog: add #8076

* Changelog: add #8100

* Changelog: add #8117

* Changelog: add #8141

* Changelog: add #8143

* Changelog: add #8147

* Changelog: add #8149

* Changelog: add #8153

* Changelog: add #8173

* Changelog: add #8184

* Changelog: add #8196

* Changelog: add #8199

* Changelog: add #8093

* Changelog: add #8171

* Changelog: add #8182

* Changelog: add #8202, #8222

* Changelog: add #8228

* Changelog: add #8240

* Changelog: add #8251

* remove AL card change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskosk oskosk oskosk approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Sharing Post sharing, sharing buttons [Pri] Normal Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.
3 participants
@jeherve @oskosk @matticbot