Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the sitemap query to disregard trashed posts. #8238

Merged
merged 1 commit into from
Nov 24, 2017

Conversation

zinigor
Copy link
Member

@zinigor zinigor commented Nov 24, 2017

Fixes a problem where after a complete regeneration of the sitemap old index files would still be included into the sitemap.

Changes proposed in this Pull Request:

  • Fixed sitemap custom post type query.
  • Added a --purge switch to the CLI rebuild command to be able to rebuild sitemaps from scratch.

Testing instructions:

  • Rebuild sitemaps using wp jetpack sitemap rebuild --purge.
  • Make sure index sitemaps do not have duplicate entries.

Proposed changelog entry for your changes:

  • Fixed the sitemap generation mechanism.

@zinigor zinigor added [Feature] Sitemaps [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended labels Nov 24, 2017
@zinigor zinigor added this to the 5.6 milestone Nov 24, 2017
@zinigor zinigor requested a review from a team as a code owner November 24, 2017 08:39
@oskosk
Copy link
Contributor

oskosk commented Nov 24, 2017

Why is this not the default behaviour for rebuild ?

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 24, 2017
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this one as it is right now, because it solves a big problem

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Merging.

@jeherve jeherve merged commit e546b19 into master Nov 24, 2017
@jeherve jeherve deleted the fix/sitemaps-query branch November 24, 2017 20:22
jeherve added a commit that referenced this pull request Nov 24, 2017
oskosk pushed a commit that referenced this pull request Nov 28, 2017
* Changelog 5.6: create base for changelog.

* Update changelog with 5.5.1 info.

* Changelog: add #7930 and #8238

* Changelog: add #8076

* Changelog: add #8100

* Changelog: add #8117

* Changelog: add #8141

* Changelog: add #8143

* Changelog: add #8147

* Changelog: add #8149

* Changelog: add #8153

* Changelog: add #8173

* Changelog: add #8184

* Changelog: add #8196

* Changelog: add #8199

* Changelog: add #8093

* Changelog: add #8171

* Changelog: add #8182

* Changelog: add #8202, #8222

* Changelog: add #8228

* Changelog: add #8240

* Changelog: add #8251

* remove AL card change
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Sitemaps Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants