Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Delete site E2E case supports native dialogs #186

Merged
merged 4 commits into from
May 30, 2024
Merged

test: Delete site E2E case supports native dialogs #186

merged 4 commits into from
May 30, 2024

Commits on May 29, 2024

  1. test: Delete site E2E case supports native dialogs 

    Playwright lacks support for interacting with native dialogs, so we mock
the dialog module to simulate the user clicking the "Delete site"
confirmation button with "Delete site files from my computer" checked.

See: microsoft/playwright#2143
See: microsoft/playwright#8278 (comment)
    @dcalhoun
    dcalhoun committed May 29, 2024
    Configuration menu
    Copy the full SHA
    97a822e View commit details
    Browse the repository at this point in the history

  2. test: Update Onboarding continue button label text

    @dcalhoun
    dcalhoun committed May 29, 2024
    Configuration menu
    Copy the full SHA
    a0c6d4d View commit details
    Browse the repository at this point in the history

  3. refactor: Fix typo

    @dcalhoun
    dcalhoun committed May 29, 2024
    Configuration menu
    Copy the full SHA
    12a2677 View commit details
    Browse the repository at this point in the history

  4. test: Improve stability of onboarding interactions 

    Combine `toBeVisible`'s interval with the ability to assert the precence
of one of multiple elements to ensure the UI is ready before
conditionally proceeding with the onboarding steps. This reduces the
likelihood that the UI is not ready when the test interactions begin and
also allows the Sites tests to succeed regardless of whether sites
already exists when the tests begin to run.
    @dcalhoun
    dcalhoun committed May 29, 2024
    Configuration menu
    Copy the full SHA
    1ab8095 View commit details
    Browse the repository at this point in the history