Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archeo (as Blockbase child) #5094

Closed
wants to merge 15 commits into from
Closed

Add archeo (as Blockbase child) #5094

wants to merge 15 commits into from

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Nov 24, 2021

Changes proposed in this Pull Request:

This is a skeleton version of Archeo:
localhost_4759_

"fontSize": "32px"
"fontSize": "var(--wp--preset--font-size--huge)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this coming from elsewhere or just a fix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a fix. I'll create a separate PR for it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scruffian
Copy link
Member Author

scruffian commented Nov 25, 2021

@kjellr @beafialho would you mind taking a look at this and seeing that else needs to be done?

From the top of my head there's:

  • Patterns
  • Color palettes

Theme URI: https://github.com/Automattic/themes/tree/trunk/archeo
Author: Automattic
Author URI: https://automattic.com
Description: A clean portfolio theme
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably need to update this.

@beafialho
Copy link
Collaborator

@kjellr @beafialho would you mind taking a look at this and seeing that else needs to be done?

Besides Patterns and Color palettes, have you added the typography styles? I also don't see any Post mockups on Figma (Small Theme V3), do we need those?

@scruffian
Copy link
Member Author

This does include the typography styles.

We don't have post mockups in the Figma, but it might be easier/quicker to do them directly in this PR. What are the changes needed?

@beafialho
Copy link
Collaborator

We don't have post mockups in the Figma, but it might be easier/quicker to do them directly in this PR.

How's that? I think we may have to iterate a bit on those.

@scruffian
Copy link
Member Author

How's that? I think we may have to iterate a bit on those.

Whatever is easier for you :)

@beafialho
Copy link
Collaborator

@scruffian here's the post page for Archeo.

Single Post

@kjellr
Copy link
Contributor

kjellr commented Nov 29, 2021

@beafialho can you include a mockup of when there's no featured image just so that's super clear? I figure the right half of the screen would just be dark gray.

@beafialho
Copy link
Collaborator

Yes, here's a mockup of when there's no featured image.

Single Post (without Featured Image)

@mikachan mikachan added the [Theme] Archeo Automatically generated label for Archeo. label Feb 1, 2022
@mikachan mikachan added this to the Archeo milestone Feb 1, 2022
@mikachan mikachan changed the title Add archeo Add archeo (as Blockbase child) Feb 1, 2022
@mikachan
Copy link
Member

mikachan commented Feb 2, 2022

Closing this in favor of #5436.

I've copied the single post mockups into a separate issue: #5423.

@mikachan mikachan closed this Feb 2, 2022
@scruffian scruffian deleted the add/archeo branch February 2, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Archeo Automatically generated label for Archeo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants