Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockbase: Update heading font size #5101

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

The "huge" size in Blockbase is 32px, so we can use the variable for the heading here.

This change will mean that child themes don't need to redeclare the font size for h2 elements, they will just need to change the font size definition.

@scruffian scruffian requested a review from a team November 25, 2021 10:24
@scruffian scruffian self-assigned this Nov 25, 2021
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to theme.json looks good to me.

I think the changes from #5100 are included here too!

@scruffian scruffian force-pushed the update/blocbase-heading-font-size branch from 2746aca to 41dd530 Compare November 25, 2021 17:11
@scruffian scruffian force-pushed the update/blocbase-heading-font-size branch from 41dd530 to f8f5f74 Compare November 25, 2021 17:11
@scruffian scruffian merged commit 90c8847 into trunk Nov 25, 2021
@scruffian scruffian deleted the update/blocbase-heading-font-size branch November 25, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants