Skip to content

Commit

Permalink
Domains: Remove duplicated validation message in StateSelect
Browse files Browse the repository at this point in the history
The problem was that in case of the text Input (when we don't have a
strict list of states for the given country), we've been showing the
`Input` component - which has its own `FormInputValidation`. This was
conflicting with the one in `StateSelect`. I've moved the one in
`StateSelect` so that it's only renendered when the `FormSelect`
implementation is used.

Fixes #12559
  • Loading branch information
Igor Klimer committed Apr 3, 2017
1 parent 321237d commit 02422cc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion client/my-sites/upgrades/components/form/state-select.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ class StateSelect extends Component {
<option key={ state.code } value={ state.code }>{ state.name }</option>
) }
</FormSelect>
{ this.props.errorMessage && <FormInputValidation text={ this.props.errorMessage } isError /> }
</div>
}
{ this.props.errorMessage && <FormInputValidation text={ this.props.errorMessage } isError /> }
</div>
);
}
Expand Down

0 comments on commit 02422cc

Please sign in to comment.