Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout UI: JavaScript error when special characters used in contact information #12559

Closed
kriskorn opened this issue Mar 27, 2017 · 2 comments
Closed

Checkout UI: JavaScript error when special characters used in contact information #12559

kriskorn opened this issue Mar 27, 2017 · 2 comments
Assignees
@klimeryk
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. OSS Citizen Post Checkout [Type] Bug

Comments

@kriskorn
Copy link
Contributor

kriskorn commented Mar 27, 2017 •
edited
Loading

Hey, Calypso Team!

Steps to reproduce

  1. Starting at URL: https://wordpress.com/checkout
  2. Register a domain.
  3. Include a special character in the contact info form for the domain (eg. ä).
  4. JavaScript error appears, which makes other fields inaccessible.

What happened instead

  1. When State is filled out with a special character, in this case "ä", there will be a double error to it:
    checkout-ui-issue-1
    The second one is rogue, which should b removed.
  2. The double error has a wrapper, which covers all the fields:
    checkout-ui-issu-2

Browser / OS version

Google Chrome 57.0 / Windows 10 Pro

Screenshot / Video

Screenshots are above in the steps.

Context / Source

#reallife #manual-testing
@rachelsquirrel rachelsquirrel added [Feature Group] Emails & Domains Features related to email integrations and domain management. [Type] Bug labels Mar 27, 2017
@klimeryk
Copy link
Contributor

@kriskorn Thanks for the report - I see the problem too. I'll have a look at it this week 👍
But please host the images on GitHub directly, so that everyone can see them :) (and won't get deleted when/if that site gets deleted/removed/etc.)

@klimeryk klimeryk self-assigned this Mar 27, 2017
@kriskorn
Copy link
Contributor Author

@klimeryk Thank you very much for the tips. All should be good now. I have replaced the images and added some clarifying steps.

klimeryk pushed a commit that referenced this issue Apr 3, 2017
Domains: Remove duplicated validation message in StateSelect
02422cc 
The problem was that in case of the text Input (when we don't have a
strict list of states for the given country), we've been showing the
`Input` component - which has its own `FormInputValidation`. This was
conflicting with the one in `StateSelect`. I've moved the one in
`StateSelect` so that it's only renendered when the `FormSelect`
implementation is used.

Fixes #12559
klimeryk pushed a commit that referenced this issue Apr 3, 2017
Domains: Convert characters to basic Latin, when possible
008232f 
The WHOIS specification does not define the required character set to be
used, but most WHOIS servers use just the basic Latin character set, so
that's what we enforce too. This change automagically converts other
characters to their basic Latin versions using the `deburr` method from
Lodash. So `ś` becomes `s`, `ą` -> `a`, etc.

Fixes #12559
klimeryk pushed a commit that referenced this issue Apr 4, 2017
@klimeryk
Domains: Convert characters to basic Latin, when possible
898a9fd 
The WHOIS specification does not define the required character set to be
used, but most WHOIS servers use just the basic Latin character set, so
that's what we enforce too. This change automagically converts other
characters to their basic Latin versions using the `deburr` method from
Lodash. So `ś` becomes `s`, `ą` -> `a`, etc.

Fixes #12559
@klimeryk klimeryk mentioned this issue Apr 4, 2017
Merged
@klimeryk klimeryk mentioned this issue Jul 20, 2017
Closed
@ockham ockham mentioned this issue Jan 29, 2019
Closed
This was referenced May 30, 2021
Open
Open
This was referenced Oct 24, 2021
Open
Open
@snyk-bot snyk-bot mentioned this issue Nov 4, 2021
Open
@ajesse11x ajesse11x mentioned this issue Oct 20, 2023
Open
@awaisab172 awaisab172 mentioned this issue Oct 20, 2023
Open
@ajesse11x ajesse11x mentioned this issue Nov 16, 2023
Open
@awaisab172 awaisab172 mentioned this issue Nov 17, 2023
Open
@awaisab172 awaisab172 mentioned this issue Mar 27, 2024
Open
@ajesse11x ajesse11x mentioned this issue Mar 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klimeryk klimeryk

Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. OSS Citizen Post Checkout [Type] Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@designsimply @klimeryk @rachelsquirrel @kriskorn @matticbot