Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: site identification #170

Closed
p3ob7o opened this issue Nov 19, 2015 · 4 comments
Closed

Purchases: site identification #170

p3ob7o opened this issue Nov 19, 2015 · 4 comments
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Enhancement

Comments

@p3ob7o
Copy link
Member

p3ob7o commented Nov 19, 2015

The list of sites in /purchases is confusing, only the site name is visible, which can be ambiguous as not unique.

We should add the blavatar and URL, like in the site picker.

@scruffian scruffian added this to the Purchases milestone Nov 19, 2015
@fabianapsimoes fabianapsimoes modified the milestones: Purchases, Purchases: v1, Purchases: v2 Nov 19, 2015
@fabianapsimoes fabianapsimoes added [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. Design and removed [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. Upgrades labels Nov 20, 2015
@fabianapsimoes
Copy link
Contributor

cc @mikeshelton1503

@fabianapsimoes fabianapsimoes modified the milestones: Purchases: v1, Purchases: v2 Nov 25, 2015
@umurkontaci
Copy link
Contributor

FWIW, we also now have the slug property in purchases list, we might be helpful.

@mikeshelton1503
Copy link
Contributor

Ok so for v1 let's just add the primary url like this:

image

I'm opting not to include the blavatar for a couple reasons:

  1. Not all users have one set so some users would just see the generic blavatar for each site which certainly doesn't help.
  2. This would be a change to the section header component that we are using here.

I think work needs to be done on the section header component to address this concern as well as others throughout the UI so keeping that change until v2 will give us time to sort out the best next steps for that component.

@breezyskies
Copy link
Contributor

@mikeshelton1503's design implemented in #2359.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

7 participants