-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purchases: Add site slug to SectionHeaders #2359
Conversation
.purchases-site__slug { | ||
color: darken( $gray, 15% ); | ||
font-size: 12px; | ||
line-height: 28px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than set a large line-height here, presumably to control the vertical alignment, you can control the vertical alignment by adding align-items: baseline
to .section-header.card
(though you would need to qualify it with .purchases-site
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Oh, one other note: It hadn't occurred to me until I saw it in action but should the site url be linked? My guts says no, however I can see users trying to click it. We could have it open the site in a new tab as to not pull users away from Purchases. I'm not sure though. @breezyskies what do you think? |
093bcae
to
927584b
Compare
Fixed so the name fades out instead of wrapping.
I don't think there's a lot of value in the linking other than the potential to fix a usability issue when users try to click. We do present slugs / domains in other areas of Calypso that do not click through, but this is a unique case since it is kind of on it's own in the design, and a different color. I could go either way on this one. |
👍 LGTM |
Purchases: Add site slug to SectionHeaders
This adds the site slug (primary domain) to the SectionHeaders for each site in
/purchases
, as suggested by @mikeshelton1503 in #170 (comment), to help make it easier to identify each site in the list.@mikeshelton1503 Note that in your original mockup, the SectionHeader label and slug were different colors, creating more hierarchy in the information presented here. I updated the color on the slug to add some contrast.