Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Me/Security: Entering two step code is not mobile friendly in a couple of places #28

Closed
hoverduck opened this issue Nov 17, 2015 · 4 comments · Fixed by #1399
Closed

Me/Security: Entering two step code is not mobile friendly in a couple of places #28

hoverduck opened this issue Nov 17, 2015 · 4 comments · Fixed by #1399
Assignees
@ebinnion
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Security [Type] Bug
Milestone
Mercury Me & Jetp...

Comments

@hoverduck
Copy link
Contributor

  1. Entering code during setup

image

  1. Verifying a backup code

image

  1. Disabling two step

image
@hoverduck hoverduck added [Type] Bug [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Security labels Nov 17, 2015
@ebinnion
Copy link
Contributor

ebinnion commented Dec 7, 2015

Hey @hoverduck, would you mind explaining the issues in these screenshots?

I notice that the buttons are misaligned quite a bit in the 3rd screenshot, but nothing is standing out to me in the other screenshots.

@hoverduck
Copy link
Contributor Author

The issue was originally raised in the pre-oss repo by @nprasath002, they may be able to provide more insight. My thought on the first screenshot is that the buttons are obscured by the keyboard, which makes it hard to click Enable after typing the code. I'm not sure about the second one either.

@nprasath002
Copy link
Contributor

Two step codes are numbers and my thought to show a number layout instead of a full keyboard

@ebinnion
Copy link
Contributor

ebinnion commented Dec 7, 2015

Ahh! Thanks for pointing that out @nprasath002. 😄 I will get that fixed up 👍

@ebinnion ebinnion self-assigned this Dec 8, 2015
@ebinnion ebinnion mentioned this issue Dec 8, 2015
Merged
sirreal pushed a commit that referenced this issue Dec 5, 2018
@umurkontaci @sirreal
i18n-no-this-translate: Add 18n-no-this-translate (#28)
4199cf7
sirreal pushed a commit that referenced this issue Dec 5, 2018
@umurkontaci @sirreal
i18n-no-this-translate: Add 18n-no-this-translate (#28)
62b62f1
sirreal pushed a commit that referenced this issue Dec 6, 2018
@umurkontaci @sirreal
i18n-no-this-translate: Add 18n-no-this-translate (#28)
919c007
sirreal pushed a commit that referenced this issue Dec 11, 2018
@umurkontaci @sirreal
i18n-no-this-translate: Add 18n-no-this-translate (#28)
9d8ba3c
jsnajdr pushed a commit that referenced this issue Jan 27, 2020
@TooTallNate @jsnajdr
Merge pull request #28 from Automattic/fix/media/new-endpoint
d69b92b 
media: append form field "media[]" instead of "media"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebinnion ebinnion

Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Security [Type] Bug
Projects
None yet
Milestone
Mercury Me & Jetpack Plans bug scrub
Development

Successfully merging a pull request may close this issue.

Me: Use FormTelInput instead of FormTextInput Automattic/wp-calypso
4 participants
@enejb @nprasath002 @ebinnion @hoverduck