Me: Use FormTelInput instead of FormTextInput #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
[Status] Needs Review
|
There's not a lot to say about this until the mobile work is done. If this is a visual regression for mobile I'm not sure we should merge it before fixing up the layout. I wish there was a way to feature-flag an already-launched feature or something. |
ebinnion
force-pushed
the
fix/me-2fa-number-input
branch
from
88f0ab4 to
8324348
Compare
|
looks good to me |
| context: '7 digit two factor code placeholder.', | ||
| textOnly: true | ||
| } ), | ||
| eightDigitBackupCodePlaceholder: i18n.translate( 'e.g. 123456', { |
There was a problem hiding this comment.
Shouldn't the example be 12345678 ?
ebinnion
force-pushed
the
fix/me-2fa-number-input
branch
from
8324348 to
dd6b9ec
Compare
|
Thanks for pointing out the incorrect placeholder for backup codes. I fixed that as well as removed the unnecessary Here's the updated screenshot of backup codes:
|
|
I just tested the app and it works really well. Great work Eric! |
enejb
added
[Status] Ready to Merge
and removed
[Status] Needs Review
ebinnion
added a commit
that referenced
this pull request
Dec 9, 2015
Me: Use FormTelInput instead of FormTextInput
lancewillett
removed
the
[Status] Needs Design Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
This PR replaces the
FormTextInputcomponents that were being used throughout 2fa withFormTelInputwhich should show a number keyboard on mobile devices.While working on that fix, I also updated placeholders to be consistent with #1386
cc @rickybanister for design review and @johnHackworth for code review.
After screenshots (Note: mobile layout will be worked on in other PRs):
To test:
fix/me-2fa-number-inputbranch/me/security/two-stepand enable/disable 2fa for a test account.Note: In the below screenshots the label and button in the application passwords section header seems off. I'm not sure what to do there, but it is unrelated to this PR.
After screenshots: