Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me: Notifications settings - alerts never go away #3203

Closed
shawnajean opened this issue Feb 9, 2016 · 12 comments
Closed

Me: Notifications settings - alerts never go away #3203

shawnajean opened this issue Feb 9, 2016 · 12 comments
Assignees
Labels
[Feature] Site Settings All other general site settings. [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug

Comments

@shawnajean
Copy link

Not only do they not timeout, they actually collect and just fill up the screen.
screenshot_08-03-2016-18 52 49
Repro by changing & saving your settings at bunch at https://wordpress.com/me/notifications

@hoverduck
Copy link
Contributor

07Apr16 Bug Scrub

Confirmed this is still a problem, although at least for me on OSX Chrome v49, the notifications stacked up along the right side of the screen, which is slightly less annoying.

@BrookeDot
Copy link
Contributor

This is still occurring upon save.

@ebinnion
Copy link
Contributor

I'm tied up with the Jetpack 4.1 release right now. Ping @rodrigoi who worked on much of this code and @artpi, who I believe updated the notification call to redux to see if they have a better idea of how to fix.

@ebinnion ebinnion removed their assignment May 20, 2016
@BrookeDot
Copy link
Contributor

Thanks for taking a look @ebinnion. This is not urgent just was at the top of the bug scrub so I was testing if it was still happening.

Coping my comment from #3254

I would like to see inline alerts where we auto-save when checking/unchecking a box instead of having to click "Save Settings" button but that may be out of the scope of this alert.

@beaulebens
Copy link
Member

I would definitely +1 this. Any of these types of simple confirmations should ideally timeout pretty quickly, and just fade/slide/whatever out of view. It's pretty infuriating that it requires user interaction to effectively confirm that you've seen a confirmation!

Since this is a broader issue than just for the "Me" section (definitely also happens in the Site Settings section), it'd probably be worth just doing a sweep through all of Calypso to standardize how they work.

@beaulebens beaulebens added the [Feature] Site Settings All other general site settings. label Jun 7, 2016
@lancewillett
Copy link
Contributor

Re-tested this today in Safari 10.0 on OS X 10.12 — using Me > Notifications settings. It seems fixed! Notifs are not piling up, I only get one occurring at the top right of the screen for each save.

@hoverduck
Copy link
Contributor

Re-opening...I'm still seeing this on Safari 10.0, Chrome v54, and Firefox v46.0. It works correctly on the main /settings pages (clearing out the old Notice when saving settings again), but the specific example below of /me/notifications doesn't clear them out:

wp-calypso-3203

@hoverduck hoverduck reopened this Oct 14, 2016
@ryanboren
Copy link
Contributor

This notification style always gets in the way of repeated operations. I let them pile up until they obscure and then Cmd+R to save clicks.

screen shot 2017-03-29 at 1 30 36 pm

@nickmomrik
Copy link

Was coming to report this bug and found this ticket. Happens to me when updating my Notification Settings in Chrome on a Mac.

screen shot 2017-07-23 at 7 52 10 am

@alisterscott
Copy link
Contributor

I noticed this testing the new Gravatar upload feature:

notice text

@apeatling apeatling modified the milestones: Product Quality, Product Quality: Setting up My Site Flows Jan 31, 2018
@apeatling apeatling added the [Pri] High Address as soon as possible after BLOCKER issues label Feb 1, 2018
@rachelmcr
Copy link
Member

I tested and confirmed this still happens on the notifications settings screen:

screenshot 2018-08-28 15 23 53

It feels especially intrusive on mobile, where the notices stack up and completely obscure the bottom of the screen:

2018-08-28 15 30 54

@alisterscott
Copy link
Contributor

Please find fix in #26943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Settings All other general site settings. [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug
Projects
None yet
Development

No branches or pull requests