me: Notifications: Stop notices from building up on screen

[alisterscott]

Ensures that notices on the Me/Notifications screen don't build up unnecessariy

Fixes #3203

Before

After

Testing Instructions

1. Visit /me/notifications
2. Make some changes and click save, then make more changes click save
3. Ensure that notices don't build up on screen
4. Ensure that after ~4 seconds the success notice automatically dismisses

[matticbot]

Test live: https://calypso.live/?branch=fix/notification-settings-confirmation

[aidvu]

LGTM!

[Stojdza]

Works as expected, mobile and desktop.

[rachelmcr]

Looks great! While testing I found a new issue #26949 but that predates this PR.

[hoverduck]

It works well on the /me/notifications page, but not elsewhere in /me. Would it be better to have a more general solution?

[alisterscott]

It works well on the /me/notifications page, but not elsewhere in /me. Would it be better to have a more general solution?

I'll open a new PR for this

[alisterscott]

It works well on the /me/notifications page, but not elsewhere in /me. Would it be better to have a more general solution?

@hoverduck do you have specific examples? I can't seem to find any testing this - only that some don't automatically disappear...

[hoverduck]

@alisterscott On further inspection this might not be that big of a deal. The alerts don't disappear, but they also don't stack up like the ones you fixed in this PR. It's maybe not ideal, but it's not nearly as irritating. This is what I saw editing any of the profile fields on the main /me page:

[Stojdza]

It looks nice when notice is refreshed after second Save, that's not the case on /me/notificatios screen. That way user is sure that saving was successful.