Jetpack: Calypso Build Breaks Image Paths From Incorrect publicPath
#56111
Assignees
Labels
Comments
|
Should be relatively easy to fix by deleting the default value for |
|
Yup, we noticed if that line was removed it worked fine. Wasn't sure if there was any other intended use for it. |
anomiex
added a commit
to Automattic/jetpack
that referenced
this issue
Oct 20, 2021
This is intended to (eventually) take care of several issues in the monorepo: * Calypso [doesn't use their own calyspo-build webpack config][1], which means it's not likely to be well-maintained. * It needs a hack to [work with monorepo packages][2]. * And another to [get correct image paths][3]. * And it [tries to redefine NODE_ENV, producing warnings][4]. * And we have to [override a weird default everywhere][5]. * We have to [name our JS files with ".min.js"][6] to avoid their being broken by a wpcom minifier, but WordPress.org's translation infrastructure [ignores such files][7]. * The plugin used to fix the above [had to be forked][8], adds 772K to the plugin, and results in spurious changes in TC builds. * The way translations are [being loaded for lazy-loaded bundles][9] is pretty hacky and doesn't lazy-load them. * We can't use any cache busting for the lazy-loaded bundles, because embedding hashes in the filename breaks the link to the translation file and putting it in a query parameter [breaks building the RTL css][10]. * Calypso-build has a lot of peer dependencies we don't actually need. Not everything we have uses sass or postcss, and we have our own infrastructure for jest, react, and so on. Currently we just ignore the 76 warnings from that. This is the first step towards fixing that: creating a private package that can hold the webpack and babel config fragments that we can share throughout the monorepo. Then we'll have a place to put the fixes for some of the other issues too. [1]: #21004 (comment) [2]: Automattic/wp-calypso#53353 [3]: Automattic/wp-calypso#56111 [4]: Automattic/wp-calypso#56291 [5]: #21004 [6]: #20484 [7]: #21343 [8]: https://github.com/Automattic/jetpack/blob/7a5edd83/projects/plugins/jetpack/tools/webpack.helpers.js#L35 [9]: #20926 [10]: #21349
anomiex
added a commit
to Automattic/jetpack
that referenced
this issue
Oct 20, 2021
This is intended to (eventually) take care of several issues in the monorepo: * Calypso [doesn't use their own calyspo-build webpack config][1], which means it's not likely to be well-maintained. * It needs a hack to [work with monorepo packages][2]. * And another to [get correct image paths][3]. * And it [tries to redefine NODE_ENV, producing warnings][4]. * And we have to [override a weird default everywhere][5]. * We have to [name our JS files with ".min.js"][6] to avoid their being broken by a wpcom minifier, but WordPress.org's translation infrastructure [ignores such files][7]. * The plugin used to fix the above [had to be forked][8], adds 772K to the plugin, and results in spurious changes in TC builds. * The way translations are [being loaded for lazy-loaded bundles][9] is pretty hacky and doesn't lazy-load them. * We can't use any cache busting for the lazy-loaded bundles, because embedding hashes in the filename breaks the link to the translation file and putting it in a query parameter [breaks building the RTL css][10]. * Calypso-build has a lot of peer dependencies we don't actually need. Not everything we have uses sass or postcss, and we have our own infrastructure for jest, react, and so on. Currently we just ignore the 76 warnings from that. This is the first step towards fixing that: creating a private package that can hold the webpack and babel config fragments that we can share throughout the monorepo. Then we'll have a place to put the fixes for some of the other issues too. [1]: #21004 (comment) [2]: Automattic/wp-calypso#53353 [3]: Automattic/wp-calypso#56111 [4]: Automattic/wp-calypso#56291 [5]: #21004 [6]: #20484 [7]: #21343 [8]: https://github.com/Automattic/jetpack/blob/7a5edd83/projects/plugins/jetpack/tools/webpack.helpers.js#L35 [9]: #20926 [10]: #21349
anomiex
added a commit
to Automattic/jetpack
that referenced
this issue
Oct 25, 2021
This is intended to (eventually) take care of several issues in the monorepo: * Calypso [doesn't use their own calyspo-build webpack config][1], which means it's not likely to be well-maintained. * It needs a hack to [work with monorepo packages][2]. * And another to [get correct image paths][3]. * And it [tries to redefine NODE_ENV, producing warnings][4]. * And we have to [override a weird default everywhere][5]. * We have to [name our JS files with ".min.js"][6] to avoid their being broken by a wpcom minifier, but WordPress.org's translation infrastructure [ignores such files][7]. * The plugin used to fix the above [had to be forked][8], adds 772K to the plugin, and results in spurious changes in TC builds. * The way translations are [being loaded for lazy-loaded bundles][9] is pretty hacky and doesn't lazy-load them. * We can't use any cache busting for the lazy-loaded bundles, because embedding hashes in the filename breaks the link to the translation file and putting it in a query parameter [breaks building the RTL css][10]. * Webpack's minification is [losing translator comments][11]. * Calypso-build has a lot of peer dependencies we don't actually need. Not everything we have uses sass or postcss, and we have our own infrastructure for jest, react, and so on. Currently we just ignore the 76 warnings from that. This is the first step towards fixing that: creating a private package that can hold the webpack and babel config fragments that we can share throughout the monorepo. Then we'll have a place to put the fixes for some of the other issues too. [1]: #21004 (comment) [2]: Automattic/wp-calypso#53353 [3]: Automattic/wp-calypso#56111 [4]: Automattic/wp-calypso#56291 [5]: #21004 [6]: #20484 [7]: #21343 [8]: https://github.com/Automattic/jetpack/blob/7a5edd83/projects/plugins/jetpack/tools/webpack.helpers.js#L35 [9]: #20926 [10]: #21349 [11]: #16549
anomiex
added a commit
to Automattic/jetpack
that referenced
this issue
Oct 28, 2021
This is intended to (eventually) take care of several issues in the monorepo: * Calypso [doesn't use their own calyspo-build webpack config][1], which means it's not likely to be well-maintained. * It needs a hack to [work with monorepo packages][2]. * And another to [get correct image paths][3]. * And it [tries to redefine NODE_ENV, producing warnings][4]. * And we have to [override a weird default everywhere][5]. * We have to [name our JS files with ".min.js"][6] to avoid their being broken by a wpcom minifier, but WordPress.org's translation infrastructure [ignores such files][7]. * The plugin used to fix the above [had to be forked][8], adds 772K to the plugin, and results in spurious changes in TC builds. * The way translations are [being loaded for lazy-loaded bundles][9] is pretty hacky and doesn't lazy-load them. * We can't use any cache busting for the lazy-loaded bundles, because embedding hashes in the filename breaks the link to the translation file and putting it in a query parameter [breaks building the RTL css][10]. * Webpack's minification is [losing translator comments][11]. * Calypso-build has a lot of peer dependencies we don't actually need. Not everything we have uses sass or postcss, and we have our own infrastructure for jest, react, and so on. Currently we just ignore the 76 warnings from that. This is the first step towards fixing that: creating a private package that can hold the webpack and babel config fragments that we can share throughout the monorepo. Then we'll have a place to put the fixes for some of the other issues too. [1]: #21004 (comment) [2]: Automattic/wp-calypso#53353 [3]: Automattic/wp-calypso#56111 [4]: Automattic/wp-calypso#56291 [5]: #21004 [6]: #20484 [7]: #21343 [8]: https://github.com/Automattic/jetpack/blob/7a5edd83/projects/plugins/jetpack/tools/webpack.helpers.js#L35 [9]: #20926 [10]: #21349 [11]: #16549
anomiex
added a commit
to Automattic/jetpack
that referenced
this issue
Oct 28, 2021
This also reverts the "bring back the "Cloud" icon, the path changed after the Webpack update" bit from #20900. The problem was Automattic/wp-calypso#56111, which is not present in the new package.
kraftbj
pushed a commit
to Automattic/jetpack
that referenced
this issue
Nov 1, 2021
This is intended to (eventually) take care of several issues in the monorepo: * Calypso [doesn't use their own calyspo-build webpack config][1], which means it's not likely to be well-maintained. * It needs a hack to [work with monorepo packages][2]. * And another to [get correct image paths][3]. * And it [tries to redefine NODE_ENV, producing warnings][4]. * And we have to [override a weird default everywhere][5]. * We have to [name our JS files with ".min.js"][6] to avoid their being broken by a wpcom minifier, but WordPress.org's translation infrastructure [ignores such files][7]. * The plugin used to fix the above [had to be forked][8], adds 772K to the plugin, and results in spurious changes in TC builds. * The way translations are [being loaded for lazy-loaded bundles][9] is pretty hacky and doesn't lazy-load them. * We can't use any cache busting for the lazy-loaded bundles, because embedding hashes in the filename breaks the link to the translation file and putting it in a query parameter [breaks building the RTL css][10]. * Webpack's minification is [losing translator comments][11]. * Calypso-build has a lot of peer dependencies we don't actually need. Not everything we have uses sass or postcss, and we have our own infrastructure for jest, react, and so on. Currently we just ignore the 76 warnings from that. This is the first step towards fixing that: creating a private package that can hold the webpack and babel config fragments that we can share throughout the monorepo. Then we'll have a place to put the fixes for some of the other issues too. [1]: #21004 (comment) [2]: Automattic/wp-calypso#53353 [3]: Automattic/wp-calypso#56111 [4]: Automattic/wp-calypso#56291 [5]: #21004 [6]: #20484 [7]: #21343 [8]: https://github.com/Automattic/jetpack/blob/7a5edd83/projects/plugins/jetpack/tools/webpack.helpers.js#L35 [9]: #20926 [10]: #21349 [11]: #16549
matticbot
pushed a commit
to Automattic/jetpack-storybook
that referenced
this issue
Nov 1, 2021
This is intended to (eventually) take care of several issues in the monorepo: * Calypso [doesn't use their own calyspo-build webpack config][1], which means it's not likely to be well-maintained. * It needs a hack to [work with monorepo packages][2]. * And another to [get correct image paths][3]. * And it [tries to redefine NODE_ENV, producing warnings][4]. * And we have to [override a weird default everywhere][5]. * We have to [name our JS files with ".min.js"][6] to avoid their being broken by a wpcom minifier, but WordPress.org's translation infrastructure [ignores such files][7]. * The plugin used to fix the above [had to be forked][8], adds 772K to the plugin, and results in spurious changes in TC builds. * The way translations are [being loaded for lazy-loaded bundles][9] is pretty hacky and doesn't lazy-load them. * We can't use any cache busting for the lazy-loaded bundles, because embedding hashes in the filename breaks the link to the translation file and putting it in a query parameter [breaks building the RTL css][10]. * Webpack's minification is [losing translator comments][11]. * Calypso-build has a lot of peer dependencies we don't actually need. Not everything we have uses sass or postcss, and we have our own infrastructure for jest, react, and so on. Currently we just ignore the 76 warnings from that. This is the first step towards fixing that: creating a private package that can hold the webpack and babel config fragments that we can share throughout the monorepo. Then we'll have a place to put the fixes for some of the other issues too. [1]: Automattic/jetpack#21004 (comment) [2]: Automattic/wp-calypso#53353 [3]: Automattic/wp-calypso#56111 [4]: Automattic/wp-calypso#56291 [5]: Automattic/jetpack#21004 [6]: Automattic/jetpack#20484 [7]: Automattic/jetpack#21343 [8]: https://github.com/Automattic/jetpack/blob/7a5edd83/projects/plugins/jetpack/tools/webpack.helpers.js#L35 [9]: Automattic/jetpack#20926 [10]: Automattic/jetpack#21349 [11]: Automattic/jetpack#16549 Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1409697994
matticbot
pushed a commit
to Automattic/jetpack-connection-ui
that referenced
this issue
Nov 1, 2021
This is intended to (eventually) take care of several issues in the monorepo: * Calypso [doesn't use their own calyspo-build webpack config][1], which means it's not likely to be well-maintained. * It needs a hack to [work with monorepo packages][2]. * And another to [get correct image paths][3]. * And it [tries to redefine NODE_ENV, producing warnings][4]. * And we have to [override a weird default everywhere][5]. * We have to [name our JS files with ".min.js"][6] to avoid their being broken by a wpcom minifier, but WordPress.org's translation infrastructure [ignores such files][7]. * The plugin used to fix the above [had to be forked][8], adds 772K to the plugin, and results in spurious changes in TC builds. * The way translations are [being loaded for lazy-loaded bundles][9] is pretty hacky and doesn't lazy-load them. * We can't use any cache busting for the lazy-loaded bundles, because embedding hashes in the filename breaks the link to the translation file and putting it in a query parameter [breaks building the RTL css][10]. * Webpack's minification is [losing translator comments][11]. * Calypso-build has a lot of peer dependencies we don't actually need. Not everything we have uses sass or postcss, and we have our own infrastructure for jest, react, and so on. Currently we just ignore the 76 warnings from that. This is the first step towards fixing that: creating a private package that can hold the webpack and babel config fragments that we can share throughout the monorepo. Then we'll have a place to put the fixes for some of the other issues too. [1]: Automattic/jetpack#21004 (comment) [2]: Automattic/wp-calypso#53353 [3]: Automattic/wp-calypso#56111 [4]: Automattic/wp-calypso#56291 [5]: Automattic/jetpack#21004 [6]: Automattic/jetpack#20484 [7]: Automattic/jetpack#21343 [8]: https://github.com/Automattic/jetpack/blob/7a5edd83/projects/plugins/jetpack/tools/webpack.helpers.js#L35 [9]: Automattic/jetpack#20926 [10]: Automattic/jetpack#21349 [11]: Automattic/jetpack#16549 Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1409697994
matticbot
pushed a commit
to Automattic/jetpack-identity-crisis
that referenced
this issue
Nov 1, 2021
This is intended to (eventually) take care of several issues in the monorepo: * Calypso [doesn't use their own calyspo-build webpack config][1], which means it's not likely to be well-maintained. * It needs a hack to [work with monorepo packages][2]. * And another to [get correct image paths][3]. * And it [tries to redefine NODE_ENV, producing warnings][4]. * And we have to [override a weird default everywhere][5]. * We have to [name our JS files with ".min.js"][6] to avoid their being broken by a wpcom minifier, but WordPress.org's translation infrastructure [ignores such files][7]. * The plugin used to fix the above [had to be forked][8], adds 772K to the plugin, and results in spurious changes in TC builds. * The way translations are [being loaded for lazy-loaded bundles][9] is pretty hacky and doesn't lazy-load them. * We can't use any cache busting for the lazy-loaded bundles, because embedding hashes in the filename breaks the link to the translation file and putting it in a query parameter [breaks building the RTL css][10]. * Webpack's minification is [losing translator comments][11]. * Calypso-build has a lot of peer dependencies we don't actually need. Not everything we have uses sass or postcss, and we have our own infrastructure for jest, react, and so on. Currently we just ignore the 76 warnings from that. This is the first step towards fixing that: creating a private package that can hold the webpack and babel config fragments that we can share throughout the monorepo. Then we'll have a place to put the fixes for some of the other issues too. [1]: Automattic/jetpack#21004 (comment) [2]: Automattic/wp-calypso#53353 [3]: Automattic/wp-calypso#56111 [4]: Automattic/wp-calypso#56291 [5]: Automattic/jetpack#21004 [6]: Automattic/jetpack#20484 [7]: Automattic/jetpack#21343 [8]: https://github.com/Automattic/jetpack/blob/7a5edd83/projects/plugins/jetpack/tools/webpack.helpers.js#L35 [9]: Automattic/jetpack#20926 [10]: Automattic/jetpack#21349 [11]: Automattic/jetpack#16549 Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1409697994
matticbot
pushed a commit
to Automattic/jetpack-backup-plugin
that referenced
this issue
Nov 1, 2021
This is intended to (eventually) take care of several issues in the monorepo: * Calypso [doesn't use their own calyspo-build webpack config][1], which means it's not likely to be well-maintained. * It needs a hack to [work with monorepo packages][2]. * And another to [get correct image paths][3]. * And it [tries to redefine NODE_ENV, producing warnings][4]. * And we have to [override a weird default everywhere][5]. * We have to [name our JS files with ".min.js"][6] to avoid their being broken by a wpcom minifier, but WordPress.org's translation infrastructure [ignores such files][7]. * The plugin used to fix the above [had to be forked][8], adds 772K to the plugin, and results in spurious changes in TC builds. * The way translations are [being loaded for lazy-loaded bundles][9] is pretty hacky and doesn't lazy-load them. * We can't use any cache busting for the lazy-loaded bundles, because embedding hashes in the filename breaks the link to the translation file and putting it in a query parameter [breaks building the RTL css][10]. * Webpack's minification is [losing translator comments][11]. * Calypso-build has a lot of peer dependencies we don't actually need. Not everything we have uses sass or postcss, and we have our own infrastructure for jest, react, and so on. Currently we just ignore the 76 warnings from that. This is the first step towards fixing that: creating a private package that can hold the webpack and babel config fragments that we can share throughout the monorepo. Then we'll have a place to put the fixes for some of the other issues too. [1]: Automattic/jetpack#21004 (comment) [2]: Automattic/wp-calypso#53353 [3]: Automattic/wp-calypso#56111 [4]: Automattic/wp-calypso#56291 [5]: Automattic/jetpack#21004 [6]: Automattic/jetpack#20484 [7]: Automattic/jetpack#21343 [8]: https://github.com/Automattic/jetpack/blob/7a5edd83/projects/plugins/jetpack/tools/webpack.helpers.js#L35 [9]: Automattic/jetpack#20926 [10]: Automattic/jetpack#21349 [11]: Automattic/jetpack#16549 Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1409697994
matticbot
pushed a commit
to Automattic/jetpack-production
that referenced
this issue
Nov 1, 2021
This is intended to (eventually) take care of several issues in the monorepo: * Calypso [doesn't use their own calyspo-build webpack config][1], which means it's not likely to be well-maintained. * It needs a hack to [work with monorepo packages][2]. * And another to [get correct image paths][3]. * And it [tries to redefine NODE_ENV, producing warnings][4]. * And we have to [override a weird default everywhere][5]. * We have to [name our JS files with ".min.js"][6] to avoid their being broken by a wpcom minifier, but WordPress.org's translation infrastructure [ignores such files][7]. * The plugin used to fix the above [had to be forked][8], adds 772K to the plugin, and results in spurious changes in TC builds. * The way translations are [being loaded for lazy-loaded bundles][9] is pretty hacky and doesn't lazy-load them. * We can't use any cache busting for the lazy-loaded bundles, because embedding hashes in the filename breaks the link to the translation file and putting it in a query parameter [breaks building the RTL css][10]. * Webpack's minification is [losing translator comments][11]. * Calypso-build has a lot of peer dependencies we don't actually need. Not everything we have uses sass or postcss, and we have our own infrastructure for jest, react, and so on. Currently we just ignore the 76 warnings from that. This is the first step towards fixing that: creating a private package that can hold the webpack and babel config fragments that we can share throughout the monorepo. Then we'll have a place to put the fixes for some of the other issues too. [1]: Automattic/jetpack#21004 (comment) [2]: Automattic/wp-calypso#53353 [3]: Automattic/wp-calypso#56111 [4]: Automattic/wp-calypso#56291 [5]: Automattic/jetpack#21004 [6]: Automattic/jetpack#20484 [7]: Automattic/jetpack#21343 [8]: https://github.com/Automattic/jetpack/blob/7a5edd83/projects/plugins/jetpack/tools/webpack.helpers.js#L35 [9]: Automattic/jetpack#20926 [10]: Automattic/jetpack#21349 [11]: Automattic/jetpack#16549 Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1409697994
anomiex
added a commit
to Automattic/jetpack
that referenced
this issue
Nov 5, 2021
* lazy-images: Use the new webpack-config package
Mostly as a proof of concept. But I also took the opportunity to clean a
few things up:
* Name the built JS as ".min.js" like it should be.
* Use copy-webpack-plugin to copy the src version of
intersection-observer.
* Use @wordpress/dependency-extraction-webpack-plugin to handle the
cache-buster version in `wp_enqueue_script()`.
* connection-ui: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
* identity-crisis: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
Also I dropped babel-minify-webpack-plugin, as terser that's included
with webpack seems to work just as well (and has been updated more
recently than 4 years ago).
* jitm: Use the new webpack-config package
This results in no change to the production build. The development build
is no longer actually minified.
* backup: Use the new webpack-config package
This also reverts the "bring back the "Cloud" icon, the path changed
after the Webpack update" bit from #20900 and similar code. The
problem was Automattic/wp-calypso#56111, which is not present in the
new package.
matticbot
pushed a commit
to Automattic/jetpack-storybook
that referenced
this issue
Nov 5, 2021
* lazy-images: Use the new webpack-config package
Mostly as a proof of concept. But I also took the opportunity to clean a
few things up:
* Name the built JS as ".min.js" like it should be.
* Use copy-webpack-plugin to copy the src version of
intersection-observer.
* Use @wordpress/dependency-extraction-webpack-plugin to handle the
cache-buster version in `wp_enqueue_script()`.
* connection-ui: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
* identity-crisis: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
Also I dropped babel-minify-webpack-plugin, as terser that's included
with webpack seems to work just as well (and has been updated more
recently than 4 years ago).
* jitm: Use the new webpack-config package
This results in no change to the production build. The development build
is no longer actually minified.
* backup: Use the new webpack-config package
This also reverts the "bring back the "Cloud" icon, the path changed
after the Webpack update" bit from #20900 and similar code. The
problem was Automattic/wp-calypso#56111, which is not present in the
new package.
Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1426089502
matticbot
pushed a commit
to Automattic/jetpack-lazy-images
that referenced
this issue
Nov 5, 2021
* lazy-images: Use the new webpack-config package
Mostly as a proof of concept. But I also took the opportunity to clean a
few things up:
* Name the built JS as ".min.js" like it should be.
* Use copy-webpack-plugin to copy the src version of
intersection-observer.
* Use @wordpress/dependency-extraction-webpack-plugin to handle the
cache-buster version in `wp_enqueue_script()`.
* connection-ui: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
* identity-crisis: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
Also I dropped babel-minify-webpack-plugin, as terser that's included
with webpack seems to work just as well (and has been updated more
recently than 4 years ago).
* jitm: Use the new webpack-config package
This results in no change to the production build. The development build
is no longer actually minified.
* backup: Use the new webpack-config package
This also reverts the "bring back the "Cloud" icon, the path changed
after the Webpack update" bit from #20900 and similar code. The
problem was Automattic/wp-calypso#56111, which is not present in the
new package.
Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1426089502
matticbot
pushed a commit
to Automattic/jetpack-identity-crisis
that referenced
this issue
Nov 5, 2021
* lazy-images: Use the new webpack-config package
Mostly as a proof of concept. But I also took the opportunity to clean a
few things up:
* Name the built JS as ".min.js" like it should be.
* Use copy-webpack-plugin to copy the src version of
intersection-observer.
* Use @wordpress/dependency-extraction-webpack-plugin to handle the
cache-buster version in `wp_enqueue_script()`.
* connection-ui: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
* identity-crisis: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
Also I dropped babel-minify-webpack-plugin, as terser that's included
with webpack seems to work just as well (and has been updated more
recently than 4 years ago).
* jitm: Use the new webpack-config package
This results in no change to the production build. The development build
is no longer actually minified.
* backup: Use the new webpack-config package
This also reverts the "bring back the "Cloud" icon, the path changed
after the Webpack update" bit from #20900 and similar code. The
problem was Automattic/wp-calypso#56111, which is not present in the
new package.
Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1426089502
matticbot
pushed a commit
to Automattic/jetpack-jitm
that referenced
this issue
Nov 5, 2021
* lazy-images: Use the new webpack-config package
Mostly as a proof of concept. But I also took the opportunity to clean a
few things up:
* Name the built JS as ".min.js" like it should be.
* Use copy-webpack-plugin to copy the src version of
intersection-observer.
* Use @wordpress/dependency-extraction-webpack-plugin to handle the
cache-buster version in `wp_enqueue_script()`.
* connection-ui: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
* identity-crisis: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
Also I dropped babel-minify-webpack-plugin, as terser that's included
with webpack seems to work just as well (and has been updated more
recently than 4 years ago).
* jitm: Use the new webpack-config package
This results in no change to the production build. The development build
is no longer actually minified.
* backup: Use the new webpack-config package
This also reverts the "bring back the "Cloud" icon, the path changed
after the Webpack update" bit from #20900 and similar code. The
problem was Automattic/wp-calypso#56111, which is not present in the
new package.
Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1426089502
matticbot
pushed a commit
to Automattic/jetpack-boost-production
that referenced
this issue
Nov 5, 2021
* lazy-images: Use the new webpack-config package
Mostly as a proof of concept. But I also took the opportunity to clean a
few things up:
* Name the built JS as ".min.js" like it should be.
* Use copy-webpack-plugin to copy the src version of
intersection-observer.
* Use @wordpress/dependency-extraction-webpack-plugin to handle the
cache-buster version in `wp_enqueue_script()`.
* connection-ui: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
* identity-crisis: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
Also I dropped babel-minify-webpack-plugin, as terser that's included
with webpack seems to work just as well (and has been updated more
recently than 4 years ago).
* jitm: Use the new webpack-config package
This results in no change to the production build. The development build
is no longer actually minified.
* backup: Use the new webpack-config package
This also reverts the "bring back the "Cloud" icon, the path changed
after the Webpack update" bit from #20900 and similar code. The
problem was Automattic/wp-calypso#56111, which is not present in the
new package.
Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1426089502
matticbot
pushed a commit
to Automattic/jetpack-connection-ui
that referenced
this issue
Nov 5, 2021
* lazy-images: Use the new webpack-config package
Mostly as a proof of concept. But I also took the opportunity to clean a
few things up:
* Name the built JS as ".min.js" like it should be.
* Use copy-webpack-plugin to copy the src version of
intersection-observer.
* Use @wordpress/dependency-extraction-webpack-plugin to handle the
cache-buster version in `wp_enqueue_script()`.
* connection-ui: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
* identity-crisis: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
Also I dropped babel-minify-webpack-plugin, as terser that's included
with webpack seems to work just as well (and has been updated more
recently than 4 years ago).
* jitm: Use the new webpack-config package
This results in no change to the production build. The development build
is no longer actually minified.
* backup: Use the new webpack-config package
This also reverts the "bring back the "Cloud" icon, the path changed
after the Webpack update" bit from #20900 and similar code. The
problem was Automattic/wp-calypso#56111, which is not present in the
new package.
Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1426089502
matticbot
pushed a commit
to Automattic/jetpack-sync
that referenced
this issue
Nov 5, 2021
* lazy-images: Use the new webpack-config package
Mostly as a proof of concept. But I also took the opportunity to clean a
few things up:
* Name the built JS as ".min.js" like it should be.
* Use copy-webpack-plugin to copy the src version of
intersection-observer.
* Use @wordpress/dependency-extraction-webpack-plugin to handle the
cache-buster version in `wp_enqueue_script()`.
* connection-ui: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
* identity-crisis: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
Also I dropped babel-minify-webpack-plugin, as terser that's included
with webpack seems to work just as well (and has been updated more
recently than 4 years ago).
* jitm: Use the new webpack-config package
This results in no change to the production build. The development build
is no longer actually minified.
* backup: Use the new webpack-config package
This also reverts the "bring back the "Cloud" icon, the path changed
after the Webpack update" bit from #20900 and similar code. The
problem was Automattic/wp-calypso#56111, which is not present in the
new package.
Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1426089502
matticbot
pushed a commit
to Automattic/jetpack-backup-plugin
that referenced
this issue
Nov 5, 2021
* lazy-images: Use the new webpack-config package
Mostly as a proof of concept. But I also took the opportunity to clean a
few things up:
* Name the built JS as ".min.js" like it should be.
* Use copy-webpack-plugin to copy the src version of
intersection-observer.
* Use @wordpress/dependency-extraction-webpack-plugin to handle the
cache-buster version in `wp_enqueue_script()`.
* connection-ui: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
* identity-crisis: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
Also I dropped babel-minify-webpack-plugin, as terser that's included
with webpack seems to work just as well (and has been updated more
recently than 4 years ago).
* jitm: Use the new webpack-config package
This results in no change to the production build. The development build
is no longer actually minified.
* backup: Use the new webpack-config package
This also reverts the "bring back the "Cloud" icon, the path changed
after the Webpack update" bit from #20900 and similar code. The
problem was Automattic/wp-calypso#56111, which is not present in the
new package.
Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1426089502
matticbot
pushed a commit
to Automattic/jetpack-production
that referenced
this issue
Nov 5, 2021
* lazy-images: Use the new webpack-config package
Mostly as a proof of concept. But I also took the opportunity to clean a
few things up:
* Name the built JS as ".min.js" like it should be.
* Use copy-webpack-plugin to copy the src version of
intersection-observer.
* Use @wordpress/dependency-extraction-webpack-plugin to handle the
cache-buster version in `wp_enqueue_script()`.
* connection-ui: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
* identity-crisis: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
Also I dropped babel-minify-webpack-plugin, as terser that's included
with webpack seems to work just as well (and has been updated more
recently than 4 years ago).
* jitm: Use the new webpack-config package
This results in no change to the production build. The development build
is no longer actually minified.
* backup: Use the new webpack-config package
This also reverts the "bring back the "Cloud" icon, the path changed
after the Webpack update" bit from #20900 and similar code. The
problem was Automattic/wp-calypso#56111, which is not present in the
new package.
Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1426089502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When we updated Jetpack to Webpack 5, it brought along this change to Calypso Build which sets the publicPath to '/'. This prevented Jetpack's previous default setting of
__webpack_public_path__from working correctly, which breaks image paths when previewing images in the block editor.In Jetpack 10.1, we used a hacky workaround to fix this for Jetpack sites, but wanted to get a clearer picture if this is intended behavior from Calypso Build, or if it's possible to provide any option to override that.
This might feed into a larger discussion about moving Jetpack away from Calypso Build to wp-scripts in the future, but wanted to reach out and get a general idea of what our options are now.
Steps to reproduce the behavior
On Jetpack 10.0 or lower (testable using the Jetpack beta plugin and choosing the 10.0 release):
Context
p1630700944248800-slack-CBG1CP4EN
Browser / OS version
All.
Is this specific to the applied theme? Which one?
No.
Does this happen on simple or atomic sites or both?
Both, but fixed for Atomic and self hosted Jetpack sites for now due to the workaround added here.
Is there any console output or error text?
Failed GET requests from calling an incorrect file path.
Level of impact (Does it block purchases? Does it affect more than just one site?)
All sites.
Reproducibility (Consistent, Intermittent) Leave empty for consistent.
Screenshot / Video: If applicable, add screenshots to help explain your problem.
cc @scinos who worked on the update, I believe.
The text was updated successfully, but these errors were encountered: