Backup: fix dashboard styling #20900
Conversation
sergeymitr
added
the
[Status] Needs Design Review
github-actions
bot
added
[Status] Design Input Requested
[Plugin] Backup
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Backup plugin:
|
|
Hey @sergeymitr, thank you so much for jumping in to fix the details. I just tested the plugin again, and I noticed we still have some spacing in between Your Site's heartbeat and Connection, for when the first backup happens, and I guess afterward as well. Can you check?
I also always get this error on a JN website, so I cannot see the next screens. Thank you 🙌 |
There was a problem hiding this comment.
@sergeymitr provided me with a screenshot on Slack and looks good to me.
sergeymitr
added
[Status] Design Review Complete
[Status] Needs Review
samiff
added
[Status] Ready to Merge
github-actions
bot
removed
the
[Status] Ready to Merge
* master: Backport Connection Package Changelog from Release (#20942) Tiled gallery: fix transform again (#20928) Jetpack Sync: Checksums: Better handling of WooCommerce tables (#20937) VideoPress Block: New Icon for Edit Button (#20916) Backup: fix dashboard styling (#20900) Connection: remove invalid user token before reconnect (#20919) Widget Visibility build tools: adjust command in readme (#20935) storybook: Use webpack 5 everywhere (#20891)
This also reverts the "bring back the "Cloud" icon, the path changed after the Webpack update" bit from #20900. The problem was Automattic/wp-calypso#56111, which is not present in the new package.
* lazy-images: Use the new webpack-config package
Mostly as a proof of concept. But I also took the opportunity to clean a
few things up:
* Name the built JS as ".min.js" like it should be.
* Use copy-webpack-plugin to copy the src version of
intersection-observer.
* Use @wordpress/dependency-extraction-webpack-plugin to handle the
cache-buster version in `wp_enqueue_script()`.
* connection-ui: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
* identity-crisis: Use the new webpack-config package
I tried not to change too much in this iteration, but I do note that the
new package uses a newer version of @wordpress/browserslist-config than
calyspo-build does so it now transpiles without IE11 support.
Also I dropped babel-minify-webpack-plugin, as terser that's included
with webpack seems to work just as well (and has been updated more
recently than 4 years ago).
* jitm: Use the new webpack-config package
This results in no change to the production build. The development build
is no longer actually minified.
* backup: Use the new webpack-config package
This also reverts the "bring back the "Cloud" icon, the path changed
after the Webpack update" bit from #20900 and similar code. The
problem was Automattic/wp-calypso#56111, which is not present in the
new package.
Changes proposed in this Pull Request:
Jetpack product discussion
p1HpG7-cGL-p2#comment-48367
Does this pull request change what data or activity we track or use?
No.
Testing instructions: