Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State: Migrate lib/sharing-buttons-list to Redux state #7928

Closed
4 tasks done
aduth opened this issue Sep 7, 2016 · 0 comments · Fixed by #10272
Closed
4 tasks done

State: Migrate lib/sharing-buttons-list to Redux state #7928

aduth opened this issue Sep 7, 2016 · 0 comments · Fixed by #10272
Assignees
@kwight @obenland
Labels
State [Type] Task
Milestone
GM Course - Redux

Comments

@aduth
Copy link
Contributor

aduth commented Sep 7, 2016 •
edited by youknowriad
Loading

Related: #5046

The lib/sharing-buttons-list emitter object is a legacy store which uses deprecated data patterns. It should be updated to align with our current data recommendations. Specifically, this may include implementing all or some of the following Redux state behaviors:

  • Reducer
  • Action creators
  • Selectors
  • Query components

The implementation of each of these behaviors should be accompanied by tests.

When submitting a pull request, reference this issue and update the checklist above to reflect progress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwight kwight

@obenland obenland

Labels
State [Type] Task
Projects
None yet
Milestone
GM Course - Redux
Development

Successfully merging a pull request may close this issue.

Sharing: Reduxify the Sharing Buttons Endpoint Automattic/wp-calypso
3 participants
@kwight @obenland @aduth