Me: 2fa Reauth Required Improvements #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
[Type] Enhancement
[Status] Needs Review
|
While you're in there, what about addressing #400
|
|
I just pushed up a commit that addresses disabling the "Verify" button when a code is not entered. I'm not sure what we're going to do with the placeholder text just yet, so I'd prefer to handle that in another PR.
|
ebinnion
changed the title
ebinnion
changed the title
|
After some clarification in Slack, I went ahead and updated the placeholder text to be
|
| } | ||
|
|
||
| return ( | ||
| <Dialog | ||
| autoFocus={ false } |
There was a problem hiding this comment.
In my testing it is necessary.
My understanding is the the Dialog component auto focuses on the content by default. So passing in autoFocus={false} short circuits that and allows us to set our own autoFocus.
See this block.
|
Looks good to me design-wise. |
|
Works as expected 🚢 |
lezama
added
[Status] Ready to Merge
and removed
[Status] Needs Review
ebinnion
added a commit
that referenced
this pull request
Dec 8, 2015
Me: 2fa Reauth Required Improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #401
Fixes #400
This PR allows auto focusing of the 2fa code input when the reauth required dialog opens in
/me.cc @v18 and @lezama for review
To test:
fix/me-reauth-autofocustwostep_authcookie/mein Calypso