Build: Add /shared path to unit test runner #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests in /shared were not being run by the test runner. Some makefiles also needed tweaking. The /shared folder will be removed soon but the tests should be run in the meantime.
ockham
force-pushed
the
fix/shared-tests
branch
from
f6abac9 to
7cea6ba
Compare
|
Rebased. |
This removes browser dependency and allows test to pass.
seear
force-pushed
the
fix/shared-tests
branch
from
175cda6 to
b5422dc
Compare
seear
added
[Status] Needs Review
|
👍 |
seear
added a commit
that referenced
this pull request
Dec 18, 2015
Build: Add /shared path to unit test runner
scruffian
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in /shared were not being run by the test runner. Some makefiles also needed tweaking. The /shared folder will be removed soon but the tests should be run in the meantime.
Let's wait until after #840 has been merged to fix the two failing Themes test sets