Themes: Remove Flux stores #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Feature Group] Appearance & Themes
ockham
force-pushed
the
remove/themes-flux-stores
branch
2 times, most recently
from
c22f768 to
bd080bf
Compare
2 tasks
ockham
force-pushed
the
remove/themes-flux-stores
branch
2 times, most recently
from
5e40a47 to
515b418
Compare
|
Note from the latest commit:
|
ockham
force-pushed
the
remove/themes-flux-stores
branch
from
a3af562 to
dbe49e4
Compare
This was referenced Dec 15, 2015
ockham
force-pushed
the
remove/themes-flux-stores
branch
from
dbe49e4 to
a03745f
Compare
This was referenced Dec 15, 2015
* `reducers/themes-last-query`: Remove Flux dispatcher `waitFor` * `reducers/themes-list`: Use `isJetpack()` from selectors instead of `ThemeLastQueryStore`'s * Kill `shared/lib/themes/stores` * Remove obsolete helper functions from reducers, now that they are in `selectors/` * Default-export reducers, don't export initialStates anymore * Update README.md * Rewrite tests in `shared/lib/themes` to directly test reducers instead of stores Note that in test/themes-list-store, the Jetpack test is removed since filtering is no longer done in the reducer but in the themes-list-fetcher data component (using the getFilteredThemes()) now.
ockham
force-pushed
the
remove/themes-flux-stores
branch
from
a03745f to
51b1aef
Compare
ockham
added
[Status] Needs Review
|
Code-wise, looks good! |
|
Feels good to slash code. |
scruffian
removed
the
[Status] Needs Review
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test:
calypso.localhost:3000/design) works as before.make testinsideshared/lib/themesChanges:
reducers/themes-last-query: Remove Flux dispatcherwaitForreducers/themes-list: UseisJetpack()from selectors instead ofThemeLastQueryStore'sshared/lib/themes/storesselectors/shared/lib/themesto directly test reducers instead of storesNote that in test/themes-list-store, the Jetpack test is removed since filtering
is no longer done in the reducer but in the themes-list-fetcher data component
(using the getFilteredThemes()) now.