Remove lib/products-list

[spen]

Note: This ended up being a huge chunk of work. I'm happy to cherry-pick out commits if that would help reviewing - just let me know :)

Summary

While I was in the air ✈️ I wanted to do some janitorial work on the project. One thing I'm always happy to do is 🔪mixin usage and anything fluxxy!

The rabbit hole I chose to dive in to on this trip was to reduce some usage of the observe mixin, in this case by removing products-list.

We we're already half way there, with products-list already having a full set of redux reducers and actions so it was more a case of plugging wires in to the right places.

Testing

Of course, everything should work exactly as before. I foresee the biggest pain point being in fetching/sync timing. The flux store had a handy getter that would fetch data where needed, something we don't have a direct mirror of with redux (the issue is solved by dispatching a fetch action via a query component)... So please be very vigilant about this point and assume that I've missed something, somewhere.

Run the full unit test suite

• run: npm run test-client - there should of course be no regressions that cause any tests to fail.

Domain Management

• List view:

  • Go to: http://calypso.localhost:3000/domains/manage/yoursite.wp.com
  • Make sure that this page works as before and displays the domains relevant to your chosen site without visual regression or errors.

• Item view:

  • Go to: http://calypso.localhost:3000/domains/manage/yoursite.wp.com/edit/yoursite.wp.com
  • Make sure that this page works as before and displays the chosen domain without visual regression or errors.

• Email

  • Coming...

Upgrades - Google Apps

Coming...

Signup - Domains

• Either log out, or open a private browsing session.
• Go through the forms, paying close attention to the domain step.
• Try using the search functionality - it should still work.
• Try selecting a domain - that should also still work.

Signup - Cart

Currently not working ❌
At the point at which the cart is built with items from signup (domain, plan etc.) the products have not been fetched or stored in redux state. The fix may be quite involved as this needs to be done via the dispatcher and needs to be synchronous (We need those products in redux before building the cart).

Checkout

• Thank You
  Coming...
• Privacy Protection
  Coming...

This is a work in progress and isn't something I can dedicate a big chunk of my own time to. I'll get there eventually but if anybody is able to help iron out the remaining issues and get a fully successful run through the complete test plan I would appreciate that very much!

I've added to the 'Reduxify Flux: One Project to Rule Them All' project board, feel free to remove if I've done so wrongly.

Seems to relate to: #5046 & #6709

[matticbot]

Test live: https://calypso.live/?branch=try/remove-lib-products-list

[spen]

Rebased.
Tagging @aidvu as there was some overlapping with some of your recent work in the rebase, want to make sure I've not undone any of your work or broke anything subtly :)

[alisterscott]

This branch needs a rebase. Is this PR still required?

[spen]

I believe this PR was superseded by other PRs 👌