Purchases: Fix site domain so that it aligns with the corresponding site name #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change align-items from baseline to stretch in order to align the site slug with the site name.
breezyskies
added
[Status] Needs Review
|
Looks good -- thanks for the fix! |
breezyskies
added
[Status] Ready to Merge
and removed
[Status] Needs Review
breezyskies
added a commit
that referenced
this pull request
Feb 9, 2016
…e-slug-with-site-name Purchases: Fix site domain so that it aligns with the corresponding site name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2690.
PR #2359 added site domains to the Section Headers in Purchases.
In Firefox, the site domain did not appear to align with the site name.
The misalignment was less noticeable in Chrome and Safari.
To test:
Before: (in Firefox)
After: (in Firefox)
cc @breezyskies