Framework: Move scroll root to avoid a scrollbar interfering with the Masterbar #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kinda related: #2929 |
|
Closing this one as no movement in several months — feel free to re-open if it's actionable and can be pushed in. |
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to avoid having a scrollbar interfere with the Masterbar, specifically in the context of the OS X app—but this could work well on the web as well. Here's a quick image to explain:
The top image shows
master. Notice that the scrollbar appears over top of the Masterbar. In the bottom image, which shows this branch, the scrollbar doesn't affect the Masterbar.One big advantage to this in the OS X app, is that it would allow us to consider a more unified Masterbar with the OS-level close/min/zoom buttons appearing within: