-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable rubberband scroll for OSX #2929
Conversation
8bb647f
to
d28bede
Compare
@@ -138,6 +138,7 @@ | |||
"phone_signup": true, | |||
"login": true, | |||
|
|||
"rubberband-scroll-disable": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this in development?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, for now I would start it with the app only and then we can change our minds
Let's get this in. |
@artpi we'd still have rubberband to the left/right edges, right? |
d28bede
to
068b8e6
Compare
Add window.navigator safeguards More verbose event name Add missing config definitions Add readme
068b8e6
to
6fee44c
Compare
Correct. Im only disabling it for top/down scroll |
…able Disable rubberband scroll for OSX
This is a new PR for this - now in wp-calypso, behind a flag.
What are you talking about?
OSX has natively this effect of 'bounce' when you are scrolling to the edge of current window.
I HATE THIS in the app.
Y u no CSS?
It is possible to achieve the same effect in CSS:
But this hides the scrollbar under masterbar and also messes with scrollbar visibility (the scrollbar disappers, but scrolling is still working)
Better solution
We discussed it with @rralian and decided that even better solution would be to play this video when while scrolling, we
push it to the limit / past the point of no return
Unfortunately, this clip is not GPL :/
Testing
Just scroll with swipe to the edge
CC @adambbecker @johngodley @dmsnell @gziolo @jasmussen