Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rubberband scroll for OSX #2929

Merged
merged 1 commit into from
Feb 15, 2016
Merged

Conversation

artpi
Copy link
Contributor

@artpi artpi commented Jan 30, 2016

This is a new PR for this - now in wp-calypso, behind a flag.

What are you talking about?

OSX has natively this effect of 'bounce' when you are scrolling to the edge of current window.
I HATE THIS in the app.

Y u no CSS?

It is possible to achieve the same effect in CSS:

html.is-desktop {
overflow:hidden;
}
html.is-desktop body {
overflow: auto;
}

But this hides the scrollbar under masterbar and also messes with scrollbar visibility (the scrollbar disappers, but scrolling is still working)

Better solution

We discussed it with @rralian and decided that even better solution would be to play this video when while scrolling, we
push it to the limit / past the point of no return
Unfortunately, this clip is not GPL :/

Testing

Just scroll with swipe to the edge

CC @adambbecker @johngodley @dmsnell @gziolo @jasmussen

@artpi artpi force-pushed the update/rubberband-scroll-disable branch 2 times, most recently from 8bb647f to d28bede Compare February 1, 2016 19:56
@artpi artpi added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 1, 2016
@@ -138,6 +138,7 @@
"phone_signup": true,
"login": true,

"rubberband-scroll-disable": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this in development?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, for now I would start it with the app only and then we can change our minds

@mtias mtias added Framework [Feature] WordPress Desktop App Features and improvements related to the WordPress Desktop App. [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 12, 2016
@mtias
Copy link
Member

mtias commented Feb 12, 2016

Let's get this in.

@mtias
Copy link
Member

mtias commented Feb 12, 2016

@artpi we'd still have rubberband to the left/right edges, right?

@artpi artpi force-pushed the update/rubberband-scroll-disable branch from d28bede to 068b8e6 Compare February 15, 2016 15:23
Add window.navigator safeguards

More verbose event name

Add missing config definitions

Add readme
@artpi artpi force-pushed the update/rubberband-scroll-disable branch from 068b8e6 to 6fee44c Compare February 15, 2016 15:25
@artpi artpi added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Author Reply labels Feb 15, 2016
@artpi
Copy link
Contributor Author

artpi commented Feb 15, 2016

we'd still have rubberband to the left/right edges, right?

Correct. Im only disabling it for top/down scroll

artpi added a commit that referenced this pull request Feb 15, 2016
@artpi artpi merged commit ea79491 into master Feb 15, 2016
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 15, 2016
@lancewillett lancewillett deleted the update/rubberband-scroll-disable branch March 11, 2016 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] WordPress Desktop App Features and improvements related to the WordPress Desktop App. Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants