-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact Info Block: Split phone numbers into prefix and phone number #31026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to be not so strict with what a phone number is and still offer a way to prefix. things.
enejb
added
the
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
label
Feb 26, 2019
lezama
reviewed
Feb 26, 2019
lezama
reviewed
Feb 26, 2019
lezama
reviewed
Feb 26, 2019
simison
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lezama
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the code comments in the code! really useful
matticbot
removed
the
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
label
Feb 27, 2019
Cherry-picked to the release branch in 7ca9928 |
jeherve
pushed a commit
that referenced
this pull request
Feb 27, 2019
…31026) * Split phone numbers into prefix and phone number This allows us to be not so strict with what a phone number is and still offer a way to prefix. things. * Fix typos and simplify selection of first character.
jeherve
added a commit
that referenced
this pull request
Mar 5, 2019
* Implement image filters for tiled gallery block * Jetpack Blocks: move a new set of blocks in production See https://github.com/Automattic/jetpack/milestone/119 * Jetpack Blocks: tag new version of the blocks for the 7.1 release * Contact Info: Fix/contact info fix sidebar (#31042) * Contact Info Block: Remove the Sidebar for google maps link * bug fix: use className instead of class * Additional keywords for the Slideshow block. (#31038) * Improvement to Autoplay delay label. (#31039) * Slideshow: Add New Uploads At End (#31046) * Add newly uploaded images to the end of the slideshow. Jump to the position of the new upload so user sees upload status. * Alternate approach using comparison of image array length in componentDidUpdate to determine position. * Contact Info: Add the ability to add the buisness hours block to the contact info (#31056) * Contact Info Block: Improve email validation (#31033) * Contact Info Block: Improve the email validation By using the emailValidator that is use in more places we can provide better matching and of email addresses. * bug fix. take into account any number of punctuation. * Business hours: show 'closed' when data is incomplete for a given interval (#31083) * Business hours If data is incomplete for a given interval, display 'Closed' or null; * adjusting logic - thanks @lezama * further improved time validation logic * Contact Info Block: Split phone numbers into prefix and phone number (#31026) * Split phone numbers into prefix and phone number This allows us to be not so strict with what a phone number is and still offer a way to prefix. things. * Fix typos and simplify selection of first character. * WordAds block: Update icon (#31106) * Business Hours: Update editor styles for consistency with UI elements * Business Hours Block: add search keywords (#31090) * Business Hours Block: add search keywords * updating terms after feedback from co-workers * Related Posts: update the message displayed when no related posts (#31126) Discussion: p8oabR-kb-p2 #comment-2590 * Tiled Gallery: Remove i18n strings in save (#31119) * Add deprecated declaration based on #30724 * Remove localized aria-label from save * Form block: fix typo (#31139) * Mailchimp: Placeholder Buttons (#31089) * Rework of button UI hierarchy in unconnected placeholder. * Change to Connection button styling. * Add isBorderless to Re-check button. * Revised button attributes for placeholder. * Further revisions to button styles. * Mailchimp: Form Element Spacing (#31142) * Standardized form element spacing in the editor. * Use rem for form element spacing. * Business hours block: use blockIcon in placeholder (#31143) * Fix: business hours validation (#31122) * When saving a business hours block, don't save any data that hinges on localization. * defaultLocalization should not be translated. * After a conversation with @sirreal - we've decided on this approach: drop the save component altogether, because we use server-side rendering for the block have a <DayEdit /> and <DayPreview /> component for client side rendering, which are only rendered once we've fetched localization * Default days should remain localized. * Tiled gallery block: camel case product name (#31184) * VideoPress: Disable re-usable block feature for video blocks (#31186) * Change contact info icon to account box (#31190) * Deselect image on filter change * Update filter icons via #30853 (comment) * Slideshow: Replace Buttons With A Tags (#31175) * Replace Slideshow buttons with A tags. Hide inner text in links. Disable ESLint rule related to anchors without HREFs. * Remove text from PREV/NEXT/PAUSE buttons, to avoid block invalidation after language change. * Reposition bullets element below buttons (no visible change). * Remove localization of text for initial autoplay Pause button state. All a11y label localization will be addressed as a later block of work. * Removing unneeded CSS now that buttons have no inner content. * Fix WordAds block alignment Remove content floating by removing conflicting align{left,right,center} classes. Gutenberg styling handles left/right alignment. Apply center alignment based on data-align attributes. * Jetpack Blocks: update blocks for the final 7.1 release. Co-authored-by: Jon Surrell <jon.surrell@automattic.com> Co-authored-by: Enej Bajgoric <enej.bajgoric@gmail.com> Co-authored-by: Jefferson Rabb <j.max.rabb@gmail.com> Co-authored-by: Rocco Tripaldi <tripaldir@gmail.com> Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com> Co-authored-by: Mikael Korpela <mikael@ihminen.org> Co-authored-by: Miguel Torres <miguelmariatorresrojas@gmail.com> Co-authored-by: Michael Turk <gititon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to be not so strict with what a phone number is and still offer a way to prefix. things.
Changes proposed in this Pull Request
Previously we did text matching for things that looked liked phone numbers and auto converted them into phone numbers. This approach worked well moist times but it didn't in some cases.
This changes take the phone number input and splits it into 2 parts.
The first part is a prefix and the other part is a phone number.
We then proceed and make the phone umber link-able. While leaving the prefix as it is.
Testing instructions