Jetpack Blocks: new version of the blocks (13.1.0) for the 7.1 release #31045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeherve
added
Jetpack
[Status] In Progress
[Goal] Gutenberg
jeherve
added a commit
to Automattic/jetpack
that referenced
this pull request
Feb 26, 2019
jeherve
added a commit
to Automattic/jetpack
that referenced
this pull request
Feb 26, 2019
* Contact Info Block: Remove the Sidebar for google maps link * bug fix: use className instead of class
* Add newly uploaded images to the end of the slideshow. Jump to the position of the new upload so user sees upload status. * Alternate approach using comparison of image array length in componentDidUpdate to determine position.
This was referenced Feb 27, 2019
* Contact Info Block: Improve the email validation By using the emailValidator that is use in more places we can provide better matching and of email addresses. * bug fix. take into account any number of punctuation.
…31026) * Split phone numbers into prefix and phone number This allows us to be not so strict with what a phone number is and still offer a way to prefix. things. * Fix typos and simplify selection of first character.
* Business Hours Block: add search keywords * updating terms after feedback from co-workers
…1126) Discussion: p8oabR-kb-p2 #comment-2590
* Add deprecated declaration based on #30724 * Remove localized aria-label from save
* Rework of button UI hierarchy in unconnected placeholder. * Change to Connection button styling. * Add isBorderless to Re-check button. * Revised button attributes for placeholder. * Further revisions to button styles.
* Standardized form element spacing in the editor. * Use rem for form element spacing.
* When saving a business hours block, don't save any data that hinges on localization. * defaultLocalization should not be translated. * After a conversation with @sirreal - we've decided on this approach: drop the save component altogether, because we use server-side rendering for the block have a <DayEdit /> and <DayPreview /> component for client side rendering, which are only rendered once we've fetched localization * Default days should remain localized.
* Replace Slideshow buttons with A tags. Hide inner text in links. Disable ESLint rule related to anchors without HREFs. * Remove text from PREV/NEXT/PAUSE buttons, to avoid block invalidation after language change. * Reposition bullets element below buttons (no visible change). * Remove localization of text for initial autoplay Pause button state. All a11y label localization will be addressed as a later block of work. * Removing unneeded CSS now that buttons have no inner content.
Remove content floating by removing conflicting align{left,right,center}
classes.
Gutenberg styling handles left/right alignment.
Apply center alignment based on data-align attributes.
jeherve
added a commit
to Automattic/jetpack
that referenced
this pull request
Mar 4, 2019
jeherve
added a commit
to Automattic/jetpack
that referenced
this pull request
Mar 4, 2019
jeherve
added a commit
to Automattic/jetpack
that referenced
this pull request
Mar 4, 2019
This was referenced Mar 5, 2019
jeherve
changed the title
jeherve
added
[Status] Needs Review
simison
approved these changes
Mar 5, 2019
simison
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions