Framework: add approach for redux data persistence #3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwwar
added
Framework
[Status] Needs Review
| reducer( browserState, { type: 'DESERIALIZE' } ) | ||
| ``` | ||
|
|
||
| The key idea is that in the reducer `SERIALIZE` should return a plain JS object. In a subtree that uses Immutable.js |
There was a problem hiding this comment.
Should we explain why it's important to return a JavaScript object?
Because browser storage is only capable of storing simple JavaScript objects, the purpose of the `SERIALIZE` action type reducer handler is to return a plain object representation.
|
The headings are a bit confusing to the flow of reading:
I might expect it to be structured as:
|
aduth
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
gwwar
force-pushed
the
add/persist-redux-documentation
branch
7 times, most recently
from
289dd21 to
7057d5a
Compare
gwwar
added
[Status] Needs Review
This was referenced Feb 17, 2016
gwwar
force-pushed
the
add/persist-redux-documentation
branch
2 times, most recently
from
0e5671e to
67dc83a
Compare
|
I think this looks great... thanks for writing it up! Looks good to 🚢 to me. |
rralian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Thanks for the reviews! Going to squash commits. |
gwwar
force-pushed
the
add/persist-redux-documentation
branch
from
67dc83a to
e22a61b
Compare
gwwar
added a commit
that referenced
this pull request
Feb 24, 2016
Framework: add approach for redux data persistence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data persistence is still a wip but I think we should update this as we go along.
cc @rralian @mtias @aduth @blowery @dmsnell @ockham