Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: enable redux persistence on horizon and dev #3483

Merged
merged 1 commit into from
Mar 1, 2016

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Feb 23, 2016

This PR turns on redux-persistence for horizon and development environments.

Before Merging:

State Tree Status

cc @rralian

@gwwar gwwar force-pushed the update/horizon-redux-persistence branch from 36a9ecb to f71a7d3 Compare February 29, 2016 20:55
@gwwar gwwar added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Mar 1, 2016
gwwar added a commit that referenced this pull request Mar 1, 2016
…ence

Framework: enable redux persistence on horizon and dev
@gwwar gwwar merged commit c884fd5 into master Mar 1, 2016
@gwwar gwwar deleted the update/horizon-redux-persistence branch March 1, 2016 01:38
@gwwar gwwar removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 1, 2016
@mtias
Copy link
Member

mtias commented Mar 8, 2016

@gwwar any reason why enabling this for horizon and not wpcalypso?

@gwwar
Copy link
Contributor Author

gwwar commented Mar 8, 2016

Ah thanks, I think I forgot to turn this on for wpcalypso. :)

@rralian
Copy link
Contributor

rralian commented Mar 8, 2016

@gwwar We should probably enable in staging as well. I think it gets more usage than horizon so we'll probably surface issues faster.

@mtias
Copy link
Member

mtias commented Mar 9, 2016

@gwwar heh, no worries :) I think in general it's good to have it in wpcalypso for a bit before hitting staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants