State: Filter connections by site via selector in place of reducer key #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
Framework
[Feature] Post/Page Editor
| return connectionsBySiteId[ siteId ].map( ( connectionId ) => { | ||
| return connections[ connectionId ]; | ||
| } ); | ||
| return filter( state.sharing.publicize.connections, { site_ID: siteId } ); |
There was a problem hiding this comment.
👍 Filter should be plenty speedy on small arrays.
|
Thanks for working on this! This should make #3357 much simpler. |
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
aduth
added a commit
that referenced
this pull request
Feb 19, 2016
…elector State: Filter connections by site via selector in place of reducer key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3357
This pull request seeks to remove the
state.sharing.publicize.connectionsBySiteIdreducer key, replacing it with filter logic contained withingetConnectionsBySiteIdandgetSiteUserConnections.Testing instructions:
Repeat testing instructions from #338.
Ensure that Mocha tests continue to pass by running
make testfromclient/state/sharing/publicize./cc @gwwar