Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Update/disable persistence without schemas #3621

Merged
merged 12 commits into from
Feb 29, 2016
Merged

Framework: Update/disable persistence without schemas #3621

merged 12 commits into from
Feb 29, 2016

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Feb 27, 2016

Before turning on persistence in Horizon in #3483, this PR turns off persistence for subtrees that are missing JSON Schemas. If it makes sense to do so, we will add them in future individual PRs.

Testing

  • Start Calypso with ENABLE_FEATURES=persist-redux make run
  • In the console set localStorage.debug to calypso:state
  • Refresh the page
  • We do not load state for subtrees that are missing JSON Schemas
  • No functional changes
  • All tests pass

cc @rralian @aduth @seear @drewblaisdell @jordwest

@gwwar gwwar added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Task labels Feb 27, 2016
@gwwar gwwar self-assigned this Feb 27, 2016
@gwwar gwwar added this to the Calypso Core: Offline 5 milestone Feb 27, 2016
@gwwar gwwar added [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] In Progress labels Feb 27, 2016
@gwwar gwwar force-pushed the update/disable-persistence-without-schemas branch 2 times, most recently from ec96101 to 62e1924 Compare February 27, 2016 00:36
@drewblaisdell
Copy link
Contributor

👍 for receipts - they aren't stored in local storage, the state/receipts tests pass, and the functionality of the components that use that branch remains unchanged.

@gwwar gwwar added [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] In Progress labels Feb 27, 2016
@gwwar gwwar force-pushed the update/disable-persistence-without-schemas branch from c7d933d to ff4cfa3 Compare February 29, 2016 17:30
@gwwar
Copy link
Contributor Author

gwwar commented Feb 29, 2016

Sites should not be persisted until #3624 is answered.

@rralian
Copy link
Contributor

rralian commented Feb 29, 2016

Code looks good, tests run, and everything is working fine for me. I give it 👍 👍

@rralian rralian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 29, 2016
gwwar added a commit that referenced this pull request Feb 29, 2016
@gwwar
Merge pull request #3621 from Automattic/update/disable-persistence-w…
dea6260 
…ithout-schemas

Framework: Update/disable persistence without schemas
@gwwar gwwar merged commit dea6260 into master Feb 29, 2016
@gwwar gwwar deleted the update/disable-persistence-without-schemas branch February 29, 2016 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gwwar gwwar

Labels
Framework [Type] Task
Projects
None yet
Milestone
Calypso Core: Offline 5
Development

Successfully merging this pull request may close these issues.
4 participants
@gwwar @drewblaisdell @rralian @scruffian