Framework: replace wpcom-private by wpcom-unpublished
#381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrofox
added
Framework
[Status] Needs Review
|
I've tested this locally on osx/chrome and it's working fine. I don't have virtualbox setup on this computer, and I'm about to switch to a different computer, so I'd rather avoid the half-day of setting it up to test this. But someone who has a simple means of testing IE11 and Edge should probably do so. And then assuming they're good, we can merge this. |
|
I tried getting BrowserStack working, but didn't have any luck. Or else this PR is just broken for IE11. But I would guess the former. Still hoping to find someone who has a working IE11 and Edge setup who can give this a sanity test. |
|
WFM in IE11 |
nb
force-pushed
the
update/wpcom-unpublished
branch
from
c4d0d4f to
726cddb
Compare
|
Let’s do it :-) |
nb
added a commit
that referenced
this pull request
Nov 23, 2015
Framework: replace `wpcom-private` by `wpcom-unpublished`
scruffian
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to rollback this #305 because we were using Promises in
wpcom.jsand it isn't supported by IE.So I've updated
wpcom-unpublishedbumping a previous version of wpcom.js to avoid Promises.cc @rralian @aduth