Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: update wpcom-unpublished to 1.0.5 #498

Merged
merged 1 commit into from
Nov 23, 2015
Merged

Framework: update wpcom-unpublished to 1.0.5 #498

merged 1 commit into from
Nov 23, 2015

Conversation

retrofox
Copy link
Contributor

Update wpcom-unpublished dependency to 1.0.5

@retrofox retrofox added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Security OSS labels Nov 23, 2015
@ockham
Copy link
Contributor

ockham commented Nov 23, 2015

One question about wpcom-unpublished's dependency on wpcom 4.6.4 (that version is unfortunately not documented in https://github.com/Automattic/wpcom.js/blob/master/History.md) -- does it rely on Promises (because some other 4.6.x versions seem to involve Promises)? (I remember something breaking because of Promises not being available in IE11, so just to make sure...)

@ockham
Copy link
Contributor

ockham commented Nov 23, 2015

Ah, found them: #350 and #381. Well I guess that's what wpcom 4.6.4 is all about then, right?

@retrofox
Copy link
Contributor Author

@ockham wpcom@4.6.4 does not rely in Promises at all. We'll update wpcom documentation.

@ockham
Copy link
Contributor

ockham commented Nov 23, 2015

Cool! In that case, LGTM!

@ockham ockham added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 23, 2015
retrofox added a commit that referenced this pull request Nov 23, 2015
@retrofox
Merge pull request #498 from Automattic/update/wpcom-unpublished-1.0.5
29b02dd 
Framework: update `wpcom-unpublished` to `1.0.5`
@retrofox retrofox merged commit 29b02dd into master Nov 23, 2015
@retrofox retrofox deleted the update/wpcom-unpublished-1.0.5 branch November 23, 2015 13:50
@ockham
Copy link
Contributor

ockham commented Nov 23, 2015

🎉

@hoverduck hoverduck mentioned this pull request Nov 23, 2015
Closed
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Framework Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@retrofox @ockham @scruffian