Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update wordpress monorepo #38554

Merged
merged 7 commits into from
Jan 13, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 20, 2019

This PR contains the following updates:

Package Type Update Change
@wordpress/api-fetch dependencies minor 3.7.0 -> 3.8.0
@wordpress/base-styles dependencies minor 1.0.0 -> 1.1.0
@wordpress/block-editor dependencies minor 3.3.0 -> 3.4.0
@wordpress/block-library dependencies minor 2.10.0 -> 2.11.0
@wordpress/blocks dependencies minor 6.8.0 -> 6.9.0
@wordpress/components dependencies minor 8.4.0 -> 8.5.0
@wordpress/compose dependencies minor 3.8.0 -> 3.9.0
@wordpress/core-data dependencies minor 2.8.0 -> 2.9.0
@wordpress/data dependencies minor 4.10.0 -> 4.11.0
@wordpress/data-controls dependencies minor 1.4.0 -> 1.5.0
@wordpress/edit-post dependencies minor 3.9.0 -> 3.10.0
@wordpress/editor dependencies minor 9.8.0 -> 9.9.0
@wordpress/element dependencies minor 2.9.0 -> 2.10.0
@wordpress/format-library dependencies minor 1.10.0 -> 1.11.0
@wordpress/jest-preset-default devDependencies minor 5.2.0 -> 5.3.0
@wordpress/notices dependencies minor 1.9.0 -> 1.10.0
@wordpress/nux dependencies minor 3.8.0 -> 3.9.0
@wordpress/plugins dependencies minor 2.8.0 -> 2.9.0
@wordpress/rich-text dependencies minor 3.8.0 -> 3.9.0
@wordpress/scripts devDependencies minor 6.0.0 -> 6.1.0
@wordpress/server-side-render dependencies minor 1.4.0 -> 1.5.0
@wordpress/url dependencies minor 2.8.2 -> 2.9.0
@wordpress/viewport dependencies minor 2.9.0 -> 2.10.0

Release Notes

WordPress/gutenberg

v3.8.0

Compare Source

  • Add Full Screen mode. 📺
  • Add UI for bulk managing reusable blocks.
  • Implement a more sophisticated Editor Styles mechanism. 🖍 It allows themes to register editor styles for blocks by targeting the blocks themselves without having to fight CSS specificity, and without having to know the internal DOM structure for the editor.
  • Move the block settings menu to the block toolbar, further consolidating the UI elements.
  • Switch to a new hand-coded default block parser implementation and expand documentation.
    • Implemented in both PHP and JS.
    • Brings great performance improvements in both time and memory.
    • Makes server-side parsing in PHP viable for accessing blocks as a tree.
  • Use flex-box to render the block inserter layout to address different issues with spacing.
  • Show a warning when a disallowed filetype is dropped on a MediaUpload.
  • Show "no archives to show" message on Archives Block.
  • Add AccessibleSVG component and use consistently for block icons.
  • Improve Classic editor and Cloudflare notification modals.
  • Refactor Draggable component to decouple the drag handle from the DOM node being dragged.
  • Move video caption styles to style.scss.
  • Treat Verse lines consistently on the front-end.
  • Make sure all available taxonomies are loaded in the editor.
  • Improve empty elements filters in Slot implementation.
  • Fix case with PostTextEditor where intended state value is not always reflected in the rendered textarea when empty.
  • Fix background clashing with some themes in Separator alternative styles.
  • Fix case where hasSelectedInnerBlock did not account for multi-selected innerBlocks. This caused an edge case in Spotlight mode where multiple blocks selected inside a column would appear unfocused.
  • Fix regression with margins around image captions.
  • Fix issue with author select overflowing on IE11.
  • Fix the publish panel top position in FullScreen mode.
  • Fix radio button alignment in post visibility menu.
  • Fix issues with centering of images.
  • Fix BlockIcon usage in embed placeholder when resource cannot be previewed.
  • Fix font size regression in PostTitle.
  • Fix codetabs block in extensibility documentation.
  • Fix import source of RangeControl in Readme file.
  • Fix broken link in documentation inside element/README.md.
  • Deprecate usage of RichText provider component.
  • Deprecate getI18n, dcnpgettext.
  • Remove deprecated selectors from docs.
  • Revert shortcut change in block-deletion e2e test.
  • Pin fetch polyfill to 3.0 UMD distributable to resolve an issue where it was no longer usable in IE11.
  • Ensure Gutenberg repository is clean after install.
  • Include block serialization default parser in plugin.
  • Change how required built-ins are polyfilled with Babel 7.

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.

@matticbot
Copy link
Contributor

@ockham
Copy link
Contributor

ockham commented Dec 29, 2019

The @wordpress/base-styles update currently breaks Gutenboarding with

ERROR in ./client/landing/gutenboarding/components/header/style.scss
Module build failed (from ./node_modules/mini-css-extract-plugin-with-rtl/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Error: Specified z-index `.edit-post-header` does not exist in the mapping
        on line 134 of node_modules/@wordpress/base-styles/_z-index.scss, in function `z-index`
        from line 12 of /home/bernie/src/wp-calypso/client/landing/gutenboarding/components/header/style.scss

The reason is WordPress/gutenberg@995aa3a#diff-1c24406914c18d0668eb1f64880d4144L28.

I'll push a fix to this PR.

@renovate renovate bot requested a review from a team as a code owner December 29, 2019 15:34
@renovate
Copy link
Contributor Author

renovate bot commented Dec 29, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@matticbot
Copy link
Contributor

matticbot commented Dec 29, 2019

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime (~59 bytes removed 📉 [gzipped])

name      parsed_size           gzip_size
manifest       -901 B  (-0.5%)      -59 B  (-0.2%)

Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded.

App Entrypoints (~3275 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       -925 B  (-0.1%)    +3275 B  (+0.7%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~29877 bytes removed 📉 [gzipped])

name              parsed_size            gzip_size
theme               -139480 B  (-35.3%)   -30798 B  (-31.5%)
themes                -2785 B   (-0.9%)     +329 B   (+0.4%)
plugins               -2785 B   (-0.6%)     +329 B   (+0.3%)
hosting               -2785 B   (-1.2%)     +329 B   (+0.5%)
import                -2397 B   (-1.2%)     -655 B   (-1.2%)
gutenberg-editor      +1593 B   (+0.2%)     +460 B   (+0.2%)
signup                 -664 B   (-0.4%)      -28 B   (-0.1%)
checkout               +631 B   (+0.1%)     +157 B   (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2792 bytes removed 📉 [gzipped])

name                                           parsed_size            gzip_size
async-load-signup-steps-import-url-onboarding      -2538 B   (-7.5%)    -1442 B  (-13.8%)
async-load-signup-steps-import-url                 -2538 B  (-10.9%)    -1350 B  (-18.9%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirreal sirreal force-pushed the renovate/wordpress-monorepo branch from 6792f34 to 2b76cdd Compare January 8, 2020 13:59
@sirreal
Copy link
Member

sirreal commented Jan 8, 2020

Rebased and updated the locks, FSE lock was unchanged and failing the tests.

@noahtallen
Copy link
Contributor

Looks like something in the WordPress jest preset is off in the FSE test:

 ● Validation Error:

  Preset @wordpress/jest-preset-default is invalid:

  The "id" argument must be of type string. Received type object
  TypeError [ERR_INVALID_ARG_TYPE]: The "id" argument must be of type string. Received type object
    at validateString (internal/validators.js:112:11)
    at Module.require (internal/modules/cjs/loader.js:845:3)
    at require (internal/modules/cjs/helpers.js:74:18)
    at setupPreset (/home/circleci/wp-calypso/apps/full-site-editing/node_modules/jest-config/build/normalize.js:230:14)
    at normalize (/home/circleci/wp-calypso/apps/full-site-editing/node_modules/jest-config/build/normalize.js:554:15)
    at readConfig (/home/circleci/wp-calypso/apps/full-site-editing/node_modules/jest-config/build/index.js:163:46)
    at readConfigs (/home/circleci/wp-calypso/apps/full-site-editing/node_modules/jest-config/build/index.js:373:26)
    at /home/circleci/wp-calypso/apps/full-site-editing/node_modules/@jest/core/build/cli/index.js:155:58
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/home/circleci/wp-calypso/apps/full-site-editing/node_modules/@jest/core/build/cli/index.js:108:24)

  Configuration Documentation:
  https://jestjs.io/docs/configuration.html

@simison
Copy link
Member

simison commented Jan 8, 2020

@noahtallen @vindl will you folks look into that FSE error?

@sirreal
Copy link
Member

sirreal commented Jan 8, 2020

There was a bug in the package. I've pulled in the patch version upgrade and expect things to be working as expected now.

@sirreal sirreal added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 8, 2020
sirreal
sirreal previously approved these changes Jan 9, 2020
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing and this is working well in development in my smoke testing 👍

Copy link
Member

@vindl vindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Dotcom FSE and didn't notice any blockers. 👍

@sirreal
Copy link
Member

sirreal commented Jan 9, 2020

This is blocked on WordPress/gutenberg#19535. There is a regression only present in production mode builds where imported stylesheets are not included.

This is an issue with the @wordpress/components package. To see the issue in development, you can set the mode to "production" in the webpack config when building Calypso.

@sirreal
Copy link
Member

sirreal commented Jan 10, 2020

Rebased.

@sirreal
Copy link
Member

sirreal commented Jan 13, 2020

I've pushed b4f0039 as a workaround for the regression. It avoids tree-shaking by importing the affected CSS file from SASS (where no tree-shaking occurs) instead of via JavaScript import.

That change can be reverted when the patched package is released.

Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work well now.

@sirreal sirreal removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2020
@sirreal sirreal self-assigned this Jan 13, 2020
@sirreal sirreal added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 13, 2020
@sirreal sirreal force-pushed the renovate/wordpress-monorepo branch from b4f0039 to e1f9673 Compare January 13, 2020 11:00
@sirreal
Copy link
Member

sirreal commented Jan 13, 2020

Rebased, attempting to fix repeated e2e failures.

@sirreal sirreal merged commit 520612e into master Jan 13, 2020
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2020
@renovate renovate bot deleted the renovate/wordpress-monorepo branch January 13, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants