fix(deps): update wordpress monorepo

[renovate]

This PR contains the following updates:

Package	Type	Update	Change
@wordpress/a11y	dependencies	minor	2.8.0 -> 2.9.0
@wordpress/api-fetch	dependencies	minor	3.12.0 -> 3.14.0
@wordpress/babel-plugin-makepot	dependencies	minor	3.4.0 -> 3.5.0
@wordpress/base-styles	dependencies	minor	1.5.0 -> 1.7.0
@wordpress/block-directory	dependencies	minor	1.6.0 -> 1.8.0
@wordpress/block-editor	dependencies	minor	3.8.0 -> 3.10.0
@wordpress/block-library	dependencies	minor	2.15.0 -> 2.17.0
@wordpress/blocks	dependencies	minor	6.13.0 -> 6.15.0
@wordpress/components	dependencies	minor	9.3.0 -> 9.5.0
@wordpress/compose	dependencies	minor	3.12.0 -> 3.14.0
@wordpress/core-data	dependencies	minor	2.13.0 -> 2.15.0
@wordpress/data	dependencies	minor	4.15.0 -> 4.17.0
@wordpress/data-controls	dependencies	minor	1.9.0 -> 1.11.0
@wordpress/dependency-extraction-webpack-plugin	dependencies	minor	2.4.0 -> 2.6.0
@wordpress/dom	dependencies	minor	2.8.0 -> 2.9.0
@wordpress/dom-ready	dependencies	minor	2.8.0 -> 2.9.0
@wordpress/e2e-test-utils	dependencies	minor	4.4.0 -> 4.6.0
@wordpress/edit-post	dependencies	minor	3.14.0 -> 3.16.0
@wordpress/editor	dependencies	minor	9.13.0 -> 9.15.0
@wordpress/element	dependencies	minor	2.12.0 -> 2.13.1
@wordpress/format-library	dependencies	minor	1.15.0 -> 1.17.0
@wordpress/i18n	dependencies	minor	3.10.0 -> 3.12.0
@wordpress/icons	dependencies	minor	1.2.0 -> 1.4.0
@wordpress/is-shallow-equal	dependencies	major	1.8.0 -> 2.0.0
@wordpress/jest-preset-default	dependencies	major	5.5.0 -> 6.0.0
@wordpress/keyboard-shortcuts	dependencies	minor	1.2.0 -> 1.4.0
@wordpress/keycodes	dependencies	minor	2.10.0 -> 2.12.0
@wordpress/media-utils	dependencies	minor	1.8.0 -> 1.10.0
@wordpress/notices	dependencies	minor	2.1.0 -> 2.3.0
@wordpress/npm-package-json-lint-config	dependencies	major	2.2.0 -> 3.0.0
@wordpress/nux	dependencies	minor	3.13.0 -> 3.15.0
@wordpress/plugins	dependencies	minor	2.13.0 -> 2.15.0
@wordpress/primitives	dependencies	minor	1.2.0 -> 1.4.0
@wordpress/priority-queue	dependencies	minor	1.5.1 -> 1.6.0
@wordpress/redux-routine	dependencies	minor	3.7.0 -> 3.8.0
@wordpress/rich-text	dependencies	minor	3.13.0 -> 3.15.0
@wordpress/scripts	dependencies	major	7.2.0 -> 9.0.0
@wordpress/server-side-render	dependencies	minor	1.9.0 -> 1.11.0
@wordpress/shortcode	dependencies	minor	2.6.0 -> 2.7.0
@wordpress/url	dependencies	minor	2.12.0 -> 2.14.0
@wordpress/viewport	dependencies	minor	2.14.0 -> 2.16.0

---

Release Notes

WordPress/gutenberg

v2.9.0

Compare Source

---

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

---

• If you want to rebase/retry this PR, check this box

---

Closes #41899 (included)

This PR has been generated by WhiteSource Renovate. View repository job log here.

[matticbot]

Test live: https://calypso.live/?branch=renovate/wordpress-monorepo

[sirreal]

#39624 is blocked on this.

[sirreal]

Added @alshakero and @andrewserong. I think helping to review and land this fits in with create gardening work.

[sirreal]

We can wait for these changes or assert some types until there's another package upgrade to include them:

• i18n: Relax sprintf arguments type WordPress/gutenberg#21919
• URL: addQueryArgs optional arguments WordPress/gutenberg#21926

Some incompatible type declarations have popped up.

[alshakero]

This PR is failing to build for reasons similar to reasons here. I'll push a fix.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~16479 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-gutenboarding       +80231 B  (+4.5%)   +16452 B  (+3.4%)
entry-main                   +49 B  (+0.0%)      +10 B  (+0.0%)
entry-login                  +45 B  (+0.0%)      +12 B  (+0.0%)
entry-domains-landing        +21 B  (+0.0%)       +5 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~2607 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
post-editor           +7748 B  (+0.4%)    +1479 B  (+0.3%)
checkout              +3562 B  (+0.3%)     +563 B  (+0.2%)
gutenberg-editor      +3406 B  (+0.4%)     +565 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[alshakero]

Review 👀

Gutenboarding

I tested Gutenboarding under this update and all works great after the small fix I sent above.

I tested the flow from start to finish with as many state mutations as possible (changed domain, site title, vertical, design, etc..). Everything seems in order and the site was created without any issues.

FSE

I tested FSE too. I had some issues get it started initially but eventually got it running.

Template modal

The template modal works great. I picked a couple of templates and all rendered fine.

The FSE Experience

I created a page and played with around a dozen blocks and all works well. The only issue I noticed is that there are a few errors messages in the console log that read

Uncaught TypeError: Cannot read property 'cancelAnimationFrame' of null
    at RichText.componentWillUnmount (index.js:1466)
    at callComponentWillUnmountWithTimer (react-dom.js?ver=16.9.0:20004)
    at HTMLUnknownElement.callCallback (react-dom.js?ver=16.9.0:341)
    at Object.invokeGuardedCallbackDev (react-dom.js?ver=16.9.0:391)
    at invokeGuardedCallback (react-dom.js?ver=16.9.0:448)
    at safelyCallComponentWillUnmount (react-dom.js?ver=16.9.0:20011)
    at commitUnmount (react-dom.js?ver=16.9.0:20431)
    at commitNestedUnmounts (react-dom.js?ver=16.9.0:20487)
    at unmountHostComponents (react-dom.js?ver=16.9.0:20783)
    at commitDeletion (react-dom.js?ver=16.9.0:20852)

This might have been introduced in WordPress/gutenberg#21105 but I'm not sure. What I'm sure of though is that this issue is introduced in this update. Because RichText component is updated from 3.13.0 to 3.14.1 and the getWindow() method (where the issue originates) is created between these two versions according to the diff (can be seen here). Make sure to Find "packages/rich-text/src/component/index.js" file and load the diff, it isn't loaded by default.

Otherwise, everything seems to work OK.

Performance

The increase in the bundle size above

App Entrypoints (~14921 bytes added 📈 [gzipped])

It seems like a deal-breaker IMO.

[ockham]

Let's avoid hardcoding 😬

Suggested change

	z-index: 1;
	z-index: z-index( '.interface-interface-skeleton__header' );

These z-index changes normally come from Gutenberg renaming selectors, e.g. when moving a component to a different package. To find the relevant change, check the commit history of https://github.com/WordPress/gutenberg/blob/master/packages/base-styles/_z-index.scss.

In this case, the relevant change was here: https://github.com/WordPress/gutenberg/pull/21335/files#diff-1c24406914c18d0668eb1f64880d4144R27

[scinos]

FYI, there is also the renovate PR #41515 that will update some types of wordpress components.
Maybe we should merge #41515 into this PR?

[simison]

This might have been introduced in WordPress/gutenberg#21105 but I'm not sure.

That's odd — so that change was slated for Gutenberg 7.9 and Simple sites are running 7.8. That shouldn't matter though since we don't really package these @wordpress/* deps into the FSE JS bundle. Those dependencies are "externalized" and we just use whatever is in wp-admin available.

(You might ask why to even test then, but it's still important we test the build since we rely on some@wordpress/*packages when building the bundle.)

[sirreal]

Rebased and fixed lockfile conflict by running yarn.

[sirreal]

It would be good to confirm wpcom-FSE and SPT template selector also works.

I believe FSE (and SPT) depend WordPress installation-provided script dependencies. @wordpress/icons is the only exception. For the most part, this shouldn't affect FSE or other plugins that use external script dependencies.

[sirreal]

Thanks for the rebase @scinos. I've retested /new and I think this is good to go!

[sirreal]

This was reverted when an error was discovered on staging. 2nd attempt in #41994