State: Remove computed attributes from Redux site object

[aduth]

Fixes #2757
Related: #4057

This pull request seeks to resolve remaining issues preventing us from persisting the Redux site state. Because some areas of the application had already depended upon site objects containing decorated attributes, changes were required to remove any such dependencies before site state could be persisted.

Testing instructions:

Ensure Mocha tests pass by running npm test

Verify that no regressions occur in affected components. Specifically:

• Themes offline (primary actions)
• Themes logged in single site (preview, button options, jetpack messaging)
• Editor (Sharing accordion connections listing, disabling, etc.)

/cc @gwwar , @ockham , @seear , @ehg

[gwwar]

Was the previous if block a bad copy, or prep for future usage?

[aduth]

Was the previous if block a bad copy, or prep for future usage?

It's my assumption, one which should be confirmed by the themes folks, that the other actions were never reached, due to the fact that selectedSite was never being passed (current use-cases render the non-connected component). It's also not as simple as replacing with sitesList.getSelectedSite(), since the sites-list module is not server-render compatible.

[ockham]

@seear ^

[seear]

It is there for future usage, but given that it doesn't work it is fine to rip it out for now.

[gwwar]

👍 Changes look good. It would be good to get another +1 on the Themes changes before merging.

I found an unrelated bug with removing connections. Let me know if you'd like an issue:

1. Connect your site to Twitter
2. Navigate to the Editor and confirm that the connection appears
3. Go back to disconnect your site from Twitter
4. Navigate to the Editor
   Expected: Connection is removed
   Actual: Connection remains until indexedDB is cleared

[aduth]

Actual: Connection remains until indexedDB is cleared

Would I be correct in assuming then that this only affects environments where Redux persistence is enabled? (May affect prioritization)

[gwwar]

Would I be correct in assuming then that this only affects environments where Redux persistence is enabled? (May affect prioritization)

I believe so, though in prod it still looks like I still need to refresh the page to see the connection removed in editor. (Navigating between the sharing section and editor doesn't update the view)

[seear]

Looks good, and the themes stuff tests out fine 👍

[aduth]

Thanks for the reviews, all.