Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(deps): update wordpress monorepo" #41974

Merged
merged 1 commit into from
May 8, 2020

Conversation

scinos
Copy link
Contributor

@scinos scinos commented May 8, 2020

Reverts #41207

@scinos scinos requested review from a team as code owners May 8, 2020 09:37
@matticbot
Copy link
Contributor

@sirreal
Copy link
Member

sirreal commented May 8, 2020

Uncaught TypeError: Cannot read property 'parentNode' of null

Coming from here:
https://github.com/WordPress/gutenberg/blob/c9ce32fb147b864d7f1d15df8ede97699ded4e91/packages/components/src/popover/index.js#L331-L335

@scinos scinos added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 8, 2020
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~16479 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-gutenboarding       -80231 B  (-4.3%)   -16452 B  (-3.3%)
entry-main                   -49 B  (-0.0%)      -10 B  (-0.0%)
entry-login                  -45 B  (-0.0%)      -12 B  (-0.0%)
entry-domains-landing        -21 B  (-0.0%)       -5 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~2607 bytes removed 📉 [gzipped])

name              parsed_size           gzip_size
post-editor           -7748 B  (-0.4%)    -1479 B  (-0.3%)
checkout              -3562 B  (-0.3%)     -563 B  (-0.2%)
gutenberg-editor      -3406 B  (-0.4%)     -565 B  (-0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirreal
Copy link
Member

sirreal commented May 8, 2020

#41899 contained some test fixes and improvements. We can recover/rebase and merge it independently.

@scinos scinos merged commit c4878c6 into master May 8, 2020
@scinos scinos deleted the revert-41207-renovate/wordpress-monorepo branch May 8, 2020 09:54
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 8, 2020
sirreal added a commit that referenced this pull request May 8, 2020
scinos pushed a commit that referenced this pull request May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants