Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance domain-picker package encapsulation #43045

Merged
merged 12 commits into from
Jun 10, 2020
Merged

Enhance domain-picker package encapsulation #43045

merged 12 commits into from
Jun 10, 2020

Commits on Jun 8, 2020

  1. Enhance domain-picker package encapsulation 

    1. No need for extenal stying to look as it should
2. No more coupling with client folder
3. No more coupling with Gutenboading (S)CSS variables
4. Move as much as possible domain-picker logic to domain-picker
5. Use stores instead of props when possible (domainCategories)
6. Clean up a lot of uneeded CSS
    @alshakero
    alshakero committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    b876c0f View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @alshakero
    alshakero committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    b41ad1c View commit details
    Browse the repository at this point in the history

  3. Match base styles version

    @alshakero
    alshakero committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    485cba1 View commit details
    Browse the repository at this point in the history

  4. Adapt to new domain-picker API changes (#43046) 

    * Adapt to new domain-picker changes

domain-picker change found in: #43045

* Fix typo in analyticsUiAlgo

* Fix handler name and self-close DomainPicker tag
    @alshakero
    alshakero committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    bbfd0bf View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. - Add getDomainSearch selector to ONBOARD store. 

    - Cleanup types and props in DomainPicker.
- Don't debouce domain input value update.
    Razvan Papadopol committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    871f54c View commit details
    Browse the repository at this point in the history

  2. - Add domainSearch to DomainPicker local state. 

    - Use initialDomainSearch prop to initialize domainSearch state.
    Razvan Papadopol committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    d7bc9d0 View commit details
    Browse the repository at this point in the history

  3. Fix styles and placeholder and domains count

    @alshakero
    alshakero committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    702172c View commit details
    Browse the repository at this point in the history

  4. Use quantity variable in API request

    @alshakero
    alshakero committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    c7bdecd View commit details
    Browse the repository at this point in the history

  5. Default to quantites based on domain-picker mode

    @alshakero
    alshakero committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    8f82d03 View commit details
    Browse the repository at this point in the history

  6. Load and display correct number of domain suggestions.

    Razvan Papadopol committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    d1770cf View commit details
    Browse the repository at this point in the history

  7. Remove margin above footer of DomainPopover

    Razvan Papadopol committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    3cc22fc View commit details
    Browse the repository at this point in the history

  8. increase specificity on domain modal in Gutenboarding

    Razvan Papadopol committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    bd1e6eb View commit details
    Browse the repository at this point in the history