-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance domain-picker package encapsulation #43045
Enhance domain-picker package encapsulation #43045
Commits on Jun 8, 2020
-
Enhance domain-picker package encapsulation
1. No need for extenal stying to look as it should 2. No more coupling with client folder 3. No more coupling with Gutenboading (S)CSS variables 4. Move as much as possible domain-picker logic to domain-picker 5. Use stores instead of props when possible (domainCategories) 6. Clean up a lot of uneeded CSS
Configuration menu - View commit details
-
Copy full SHA for b876c0f - Browse repository at this point
Copy the full SHA b876c0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b41ad1c - Browse repository at this point
Copy the full SHA b41ad1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 485cba1 - Browse repository at this point
Copy the full SHA 485cba1View commit details -
Adapt to new domain-picker API changes (#43046)
* Adapt to new domain-picker changes domain-picker change found in: #43045 * Fix typo in analyticsUiAlgo * Fix handler name and self-close DomainPicker tag
Configuration menu - View commit details
-
Copy full SHA for bbfd0bf - Browse repository at this point
Copy the full SHA bbfd0bfView commit details
Commits on Jun 9, 2020
-
- Add getDomainSearch selector to ONBOARD store.
- Cleanup types and props in DomainPicker. - Don't debouce domain input value update.
Razvan Papadopol committedJun 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 871f54c - Browse repository at this point
Copy the full SHA 871f54cView commit details -
- Add domainSearch to DomainPicker local state.
- Use initialDomainSearch prop to initialize domainSearch state.
Razvan Papadopol committedJun 9, 2020 Configuration menu - View commit details
-
Copy full SHA for d7bc9d0 - Browse repository at this point
Copy the full SHA d7bc9d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 702172c - Browse repository at this point
Copy the full SHA 702172cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7bdecd - Browse repository at this point
Copy the full SHA c7bdecdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f82d03 - Browse repository at this point
Copy the full SHA 8f82d03View commit details -
Load and display correct number of domain suggestions.
Razvan Papadopol committedJun 9, 2020 Configuration menu - View commit details
-
Copy full SHA for d1770cf - Browse repository at this point
Copy the full SHA d1770cfView commit details -
Remove margin above footer of DomainPopover
Razvan Papadopol committedJun 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 3cc22fc - Browse repository at this point
Copy the full SHA 3cc22fcView commit details -
increase specificity on domain modal in Gutenboarding
Razvan Papadopol committedJun 9, 2020 Configuration menu - View commit details
-
Copy full SHA for bd1e6eb - Browse repository at this point
Copy the full SHA bd1e6ebView commit details