-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance domain-picker package encapsulation #43045
Merged
razvanpapadopol
merged 12 commits into
master
from
update/domain-picker-better-encapsulation
Jun 10, 2020
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b876c0f
Enhance domain-picker package encapsulation
alshakero b41ad1c
Address review comments
alshakero 485cba1
Match base styles version
alshakero bbfd0bf
Adapt to new domain-picker API changes (#43046)
alshakero 871f54c
- Add getDomainSearch selector to ONBOARD store.
d7bc9d0
- Add domainSearch to DomainPicker local state.
702172c
Fix styles and placeholder and domains count
alshakero c7bdecd
Use quantity variable in API request
alshakero 8f82d03
Default to quantites based on domain-picker mode
alshakero d1770cf
Load and display correct number of domain suggestions.
3cc22fc
Remove margin above footer of DomainPopover
bd1e6eb
increase specificity on domain modal in Gutenboarding
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
export const PAID_DOMAINS_TO_SHOW_WITH_CATEGORIES_MODE = 10; | ||
export const PAID_DOMAINS_TO_SHOW_WITHOUT_CATEGORIES_MODE = 5; | ||
export const DOMAIN_SEARCH_DEBOUNCE_INTERVAL = 300; | ||
export const DOMAIN_SUGGESTION_VENDOR = 'variation4_front'; | ||
export const DOMAIN_SUGGESTIONS_STORE = 'automattic/domains/suggestions'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
@import '../mixins'; | ||
@import '../styles/mixins'; | ||
|
||
.domain-categories { | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After moving
domainCategory
state intoDomainPicker
component, the selected domain category is no longer persisted after closing Domain Modal. Is this something we want? cc: @dubielzykThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently in production: after I've selected a domain category and then confirm de selection, next time I open the Domain Modal, I find that category already selected.
On this branch: category selection isn't saved from one DomainModal interaction opening to another: https://cloudup.com/cgXioTPqRx6