[TeamCity] - Set node default version on the prepare job #45722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the "Prepare environment" to install node from
.nvmr. Turns outnvm.sh --installinstalls the version configured as 'default' in nvm, not the version in.nvmrc.The process is now:
In prepare job:
nvm.sh, do not try to use .nvmrc (in case it points to a version not installed yet)nvm installwill install and use the version indicated in.nvmrc.nvmrcas the default version for nvm.In other jobs (unchanged):
nvm.sh. Will try use the version from .nvmrc, which is already installed.Testing instructions
Validate that TeamCity build passes.