Update node version from 12.18.0 to 12.18.4 across the whole repo #45721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
Blocked by #45722 |
scinos
force-pushed
the
fix/update-node-veresion
branch
from
48d9c41
to
3e7c450
Compare
tyxla
approved these changes
Sep 17, 2020
Good catch! We don't have to, but I guess it is more consistent. |
scinos
commented
Sep 17, 2020
| @@ -176,7 +175,8 @@ object RunAllUnitTests : BuildType({ | |||
| export NODE_ENV="test" | |||
|
|
|||
| # Update node | |||
| . "${'$'}NVM_DIR/nvm.sh" | |||
| . "${'$'}NVM_DIR/nvm.sh" --no-use | |||
There was a problem hiding this comment.
I'm not 100% sure why, but the previous code was not picking the new node version. I tested this config using TeamCity custom builds + a patch, and it seems to work.
matticbot
removed
the
[Status] Needs Review
mokagio
added a commit
that referenced
this pull request
Oct 5, 2020
Doing this as suggested by @scinos to make sure all the changes in this branch build under the this version, which is what master has been using since eea8ef6 (#45721). This is an extra caution step, but a useful one nonetheless. Given the merge strategy for PRs in Calypso at the time of writing is "Squash and merge" this change won't even make it into `master`, as it's already there. Normally, I would rebase the branch on top of the base branch to work around this kind of issues, but given this is a release branch it would not be appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
A high severity issue (CVE-2020-8201) was found in all Node version, Node released patched versions for v10,x, v12.x and v14.x lines
https://nodejs.org/en/blog/vulnerability/september-2020-security-releases/
Changes
Update Node from 12.18.0 to 12.18.4 across the whole repo.
Testing instructions
Verify all tests pass